From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758804AbZD2FBT (ORCPT ); Wed, 29 Apr 2009 01:01:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755803AbZD2E7P (ORCPT ); Wed, 29 Apr 2009 00:59:15 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:59495 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755061AbZD2E7O (ORCPT ); Wed, 29 Apr 2009 00:59:14 -0400 Date: Tue, 28 Apr 2009 21:50:50 -0700 From: Andrew Morton To: Nathan Lynch Cc: Wu Fengguang , "linux-kernel\@vger.kernel.org" , "kosaki.motohiro\@jp.fujitsu.com" , "andi\@firstfloor.org" , "mpm\@selenic.com" , "adobriyan\@gmail.com" , "linux-mm\@kvack.org" , Stephen Rothwell , Chandra Seetharaman , Olof Johansson , Helge Deller , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 5/5] proc: export more page flags in /proc/kpageflags Message-Id: <20090428215050.67b7b4db.akpm@linux-foundation.org> In-Reply-To: References: <20090428010907.912554629@intel.com> <20090428014920.769723618@intel.com> <20090428143244.4e424d36.akpm@linux-foundation.org> <20090429023842.GA10266@localhost> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Apr 2009 23:41:52 -0500 Nathan Lynch wrote: > > CONFIG_DEBUG_KERNEL being enabled in distro kernels effectively means > > > > #ifdef CONFIG_DEBUG_KERNEL == #if 1 > > > > as the following patch demos. Now it becomes obviously silly. > > Sure, #if 1 is usually silly. But if the point is that DEBUG_KERNEL is > not supposed to directly affect code generation, then I see two options > for powerpc: > > - remove the #ifdef CONFIG_DEBUG_KERNEL guards from > arch/powerpc/kernel/sysfs.c, unconditionally enabling the hid/ima > sysfs attributes, or > > - define a new config symbol which governs whether those attributes are > enabled, and make it depend on DEBUG_KERNEL yup. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 961536B0047 for ; Wed, 29 Apr 2009 00:57:48 -0400 (EDT) Date: Tue, 28 Apr 2009 21:50:50 -0700 From: Andrew Morton Subject: Re: [PATCH 5/5] proc: export more page flags in /proc/kpageflags Message-Id: <20090428215050.67b7b4db.akpm@linux-foundation.org> In-Reply-To: References: <20090428010907.912554629@intel.com> <20090428014920.769723618@intel.com> <20090428143244.4e424d36.akpm@linux-foundation.org> <20090429023842.GA10266@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Nathan Lynch Cc: Wu Fengguang , "linux-kernel@vger.kernel.org" , "kosaki.motohiro@jp.fujitsu.com" , "andi@firstfloor.org" , "mpm@selenic.com" , "adobriyan@gmail.com" , "linux-mm@kvack.org" , Stephen Rothwell , Chandra Seetharaman , Olof Johansson , Helge Deller , linuxppc-dev@ozlabs.org List-ID: On Tue, 28 Apr 2009 23:41:52 -0500 Nathan Lynch wrote: > > CONFIG_DEBUG_KERNEL being enabled in distro kernels effectively means > > > > #ifdef CONFIG_DEBUG_KERNEL == #if 1 > > > > as the following patch demos. Now it becomes obviously silly. > > Sure, #if 1 is usually silly. But if the point is that DEBUG_KERNEL is > not supposed to directly affect code generation, then I see two options > for powerpc: > > - remove the #ifdef CONFIG_DEBUG_KERNEL guards from > arch/powerpc/kernel/sysfs.c, unconditionally enabling the hid/ima > sysfs attributes, or > > - define a new config symbol which governs whether those attributes are > enabled, and make it depend on DEBUG_KERNEL yup. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.linux-foundation.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 606F9DDF07 for ; Wed, 29 Apr 2009 14:58:48 +1000 (EST) Date: Tue, 28 Apr 2009 21:50:50 -0700 From: Andrew Morton To: Nathan Lynch Subject: Re: [PATCH 5/5] proc: export more page flags in /proc/kpageflags Message-Id: <20090428215050.67b7b4db.akpm@linux-foundation.org> In-Reply-To: References: <20090428010907.912554629@intel.com> <20090428014920.769723618@intel.com> <20090428143244.4e424d36.akpm@linux-foundation.org> <20090429023842.GA10266@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Stephen Rothwell , Helge, Seetharaman , Deller , linuxppc-dev@ozlabs.org, "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "andi@firstfloor.org" , Chandra, "kosaki.motohiro@jp.fujitsu.com" , "mpm@selenic.com" , Olof Johansson , Wu Fengguang , "adobriyan@gmail.com" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 28 Apr 2009 23:41:52 -0500 Nathan Lynch wrote: > > CONFIG_DEBUG_KERNEL being enabled in distro kernels effectively means > > > > #ifdef CONFIG_DEBUG_KERNEL == #if 1 > > > > as the following patch demos. Now it becomes obviously silly. > > Sure, #if 1 is usually silly. But if the point is that DEBUG_KERNEL is > not supposed to directly affect code generation, then I see two options > for powerpc: > > - remove the #ifdef CONFIG_DEBUG_KERNEL guards from > arch/powerpc/kernel/sysfs.c, unconditionally enabling the hid/ima > sysfs attributes, or > > - define a new config symbol which governs whether those attributes are > enabled, and make it depend on DEBUG_KERNEL yup.