All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Lionel Landwerlin <lionel.landwerlin@openwide.fr>,
	Nathan Froyd <froydnj@codesourcery.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
Date: Wed, 29 Apr 2009 21:35:52 +0100	[thread overview]
Message-ID: <20090429203552.GB20993@shareable.org> (raw)
In-Reply-To: <20090429180048.GA19011@kos.to>

Riku Voipio wrote:
> On Mon, Apr 27, 2009 at 08:05:06PM +0200, Lionel Landwerlin wrote:
> > Le lundi 27 avril 2009 à 10:21 -0700, Nathan Froyd a écrit :
> > > On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote:
> > > > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
> 
> > > Should these be TARGET_IP_* instead, or are they like the FUTEX_*
> > > constants and the same on every platform?  If the latter, at the very
> > > least there should be explanatory comments somewhere--just making them
> > > TARGET_IP_* would be even better, IMHO.
> 
> > I'm agree too, I just did the way it was before...
> 
> These are defined in include/linux/in.h so they should be same on all archs?

But what if you're compiling for a non-Linux host?

IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP are standard BSD sockets options,
found everywhere, even on Windows I think.

-- Jamie

  reply	other threads:[~2009-04-29 20:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-25 21:30 [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt Lionel Landwerlin
2009-04-27 17:21 ` Nathan Froyd
2009-04-27 18:05   ` Lionel Landwerlin
2009-04-29 18:00     ` Riku Voipio
2009-04-29 20:35       ` Jamie Lokier [this message]
2009-04-29 20:43         ` Riku Voipio
2009-04-29 21:00           ` Jamie Lokier
2009-04-29 21:41             ` Riku Voipio
2009-04-30  2:41               ` Jamie Lokier
2009-04-29 23:08         ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090429203552.GB20993@shareable.org \
    --to=jamie@shareable.org \
    --cc=froydnj@codesourcery.com \
    --cc=lionel.landwerlin@openwide.fr \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.