From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S932065AbZD2VYT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932065AbZD2VYT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Apr 2009 17:24:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753444AbZD2VYH
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 29 Apr 2009 17:24:07 -0400
Received: from mx3.mail.elte.hu ([157.181.1.138]:40636 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753387AbZD2VYE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Apr 2009 17:24:04 -0400
Date: Wed, 29 Apr 2009 23:23:17 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Suresh Siddha <suresh.b.siddha@intel.com>,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       Rusty Russell <rusty@rustcorp.com.au>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/irq: using move_irq_desc
Message-ID: <20090429212317.GA30147@elte.hu>
References: <49E802CE.5030406@kernel.org> <49E804AD.9020702@kernel.org> <49F6559F.7070005@kernel.org> <20090428101448.GA28495@elte.hu> <49F70FED.3040903@kernel.org> <20090428143254.GA24351@elte.hu> <49F753DF.6040104@kernel.org> <20090429120056.GE11586@elte.hu> <49F87FF3.1090600@kernel.org> <20090429204135.GF21421@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20090429204135.GF21421@elte.hu>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-ELTE-VirusStatus: clean
X-ELTE-SpamScore: -1.5
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
	-1.5 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Yinghai Lu <yinghai@kernel.org> wrote:
> 
> > 
> > move_irq_desc will try to move irq_desc to node wanted if allocated one is not correct.
> > (happen on device on different nodes that are using MSI, drivers are loaded and unloaded
> > randomly)
> > 
> > [ Impact: make irq_desc go with device on node ]
> > 
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > 
> > ---
> >  arch/x86/kernel/apic/io_apic.c |    6 +-----
> >  include/linux/irq.h            |    4 ++++
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> applied, thanks. I'll look into merging it into the irq tree 
> tomorrow and testing it.

gave it a brief try and got:

kernel/irq/numa_migrate.c: In function ‘init_copy_one_irq_desc’:
kernel/irq/numa_migrate.c:46: error: ‘struct irq_desc’ has no member named ‘node’
kernel/irq/numa_migrate.c: In function ‘move_irq_desc’:
kernel/irq/numa_migrate.c:114: error: ‘struct irq_desc’ has no member named ‘node’
kernel/irq/numa_migrate.c:114: error: ‘struct irq_desc’ has no member named ‘node’
kernel/irq/numa_migrate.c:114: error: ‘struct irq_desc’ has no member named ‘node’

	Ingo