From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzMD1-00087w-Hr for qemu-devel@nongnu.org; Wed, 29 Apr 2009 22:41:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzMCx-00086t-1Y for qemu-devel@nongnu.org; Wed, 29 Apr 2009 22:41:11 -0400 Received: from [199.232.76.173] (port=58977 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzMCw-00086q-Ov for qemu-devel@nongnu.org; Wed, 29 Apr 2009 22:41:06 -0400 Received: from mail2.shareable.org ([80.68.89.115]:38386) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LzMCw-000641-DN for qemu-devel@nongnu.org; Wed, 29 Apr 2009 22:41:06 -0400 Date: Thu, 30 Apr 2009 03:41:02 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt Message-ID: <20090430024102.GA3011@shareable.org> References: <1240695019.21332.1.camel@coalu.atr> <20090427172134.GA23911@codesourcery.com> <1240855506.29022.1.camel@coalu.atr> <20090429180048.GA19011@kos.to> <20090429203552.GB20993@shareable.org> <20090429204316.GA28836@kos.to> <20090429210018.GA27613@shareable.org> <20090429214124.GA32434@kos.to> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090429214124.GA32434@kos.to> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: qemu-devel@nongnu.org, Nathan Froyd Riku Voipio wrote: > On Wed, Apr 29, 2009 at 10:00:18PM +0100, Jamie Lokier wrote: > > Riku Voipio wrote: > > > On Wed, Apr 29, 2009 at 09:35:52PM +0100, Jamie Lokier wrote: > > > > Riku Voipio wrote: > > > > > These are defined in include/linux/in.h so they should be same on all archs? > > > > > > > But what if you're compiling for a non-Linux host? > > > > > > Generally speaking if you comple Qemu Linux-user on a non-Linux host you > > > just fail. With or without this patch. > > > Oh. Are non-Linux hosts officially not supported, or is this just a > > matter of some things being broken? > > It is not officially supported. There are just too many places in the > current linux-user code that expect a linux host. Thou there has been > interest in working those bits to be more generic recently. recently. If there's real interest in working those bits for other hosts, *new* bits should use TARGET_ constants to avoid making life even harder when it comes to finding places where'll they need to be changed to TARGET_ later. -- Jamie