From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755817AbZEAHJa (ORCPT ); Fri, 1 May 2009 03:09:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753028AbZEAHJU (ORCPT ); Fri, 1 May 2009 03:09:20 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:33536 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621AbZEAHJT (ORCPT ); Fri, 1 May 2009 03:09:19 -0400 Date: Fri, 1 May 2009 09:09:11 +0200 From: Ingo Molnar To: Frederic Weisbecker Cc: LKML , Jeff Mahoney , ReiserFS Development List , Chris Mason , Alexander Beregalov , Alessio Igor Bogani , Jonathan Corbet , Alexander Viro Subject: Re: [PATCH 2/6] kill-the-BKL/reiserfs: release the write lock before rescheduling on do_journal_end() Message-ID: <20090501070911.GG5983@elte.hu> References: <1241145862-21700-1-git-send-email-fweisbec@gmail.com> <1241145862-21700-3-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1241145862-21700-3-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > When do_journal_end() copies data to the journal blocks buffers in memory, > it reschedules if needed between each block copied and dirtyfied. > > We can also release the write lock at this rescheduling stage, > like did the bkl implicitly. > > [ Impact: release the reiserfs write lock when it is not needed ] > > Cc: Jeff Mahoney > Cc: Chris Mason > Cc: Alexander Beregalov > Signed-off-by: Frederic Weisbecker > --- > fs/reiserfs/journal.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c > index 7976d7d..373d080 100644 > --- a/fs/reiserfs/journal.c > +++ b/fs/reiserfs/journal.c > @@ -4232,7 +4232,9 @@ static int do_journal_end(struct reiserfs_transaction_handle *th, > next = cn->next; > free_cnode(sb, cn); > cn = next; > + reiserfs_write_unlock(sb); > cond_resched(); > + reiserfs_write_lock(sb); There's 8 cond_resched()'s in the code - i'd suggest to introduce a helper for this - reiserfs_write_cond_resched(sb) or so? Ingo