From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 1/8] PM: Add suspend block api. Date: Sat, 2 May 2009 22:51:37 +0200 Message-ID: <20090502205137.GA1435@elf.ucw.cz> References: <1239759692-28617-1-git-send-email-arve@android.com> <200904300034.09837.rjw@sisk.pl> <200905021414.32565.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <200905021414.32565.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: ncunningham@crca.org.au, u.luckas@road.de, swetland@google.com, linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org Hi! > > >> +config SUSPEND_BLOCK > > >> + bool "Suspend block" > > >> + depends on PM > > >> + select RTC_LIB > > > > > > depends on RTC_LIB > > > > > > select doesn't really work and I don't think it ever will. > > > > Nothing depends on RTC_LIB, it is only selected. > > If nothing in your code needs anything depending on RTC_LIB, why select it? He wants to say nothing in _kernel proper_ depends on RTC_LIB: pavel@amd:/data/l/linux-good$ grep 'select RTC_LIB' `find . -name "Kconfig"` ./arch/arm/Kconfig: select RTC_LIB ./arch/mips/Kconfig: select RTC_LIB ./drivers/rtc/Kconfig: select RTC_LIB pavel@amd:/data/l/linux-good$ grep 'depends.*RTC_LIB' `find . -name "Kconfig"` pavel@amd:/data/l/linux-good$ RTC_LIB seems to be designed for select. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html