From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6] Marvell Kirkwood family SOC support
Date: Tue, 5 May 2009 00:08:37 +0200 [thread overview]
Message-ID: <20090504220837.GB13923@game.jcrosoft.org> (raw)
In-Reply-To: <1241448843-25860-1-git-send-email-prafulla@marvell.com>
> +#ifdef CONFIG_KIRKWOOD_EGIGA_INIT
> + /*
> + * Set egiga port0/1 in normal functional mode
> + * This is required becasue on kirkwood by default ports are in reset mode
> + * OS egiga driver may not have provision to set them in normal mode
> + * and if u-boot is build without network support, network may fail at OS level
> + */
> + reg = readl((KW_EGIGA0_BASE + 0x44c)); /* PORT_SERIAL_CONTROL1_REG */
so please define it and use
it
> + reg &= ~(1 << 4); /* Clear PortReset Bit */
> + writel(reg, (KW_EGIGA0_BASE + 0x44c)); /* PORT_SERIAL_CONTROL1_REG */
> + reg = readl((KW_EGIGA1_BASE + 0x44c)); /* PORT_SERIAL_CONTROL1_REG */
> + reg &= ~(1 << 4); /* Clear PortReset Bit */
> + writel(reg, (KW_EGIGA1_BASE + 0x44c)); /* PORT_SERIAL_CONTROL1_REG */
> +#endif
> +#ifdef CONFIG_KIRKWOOD_PCIE_INIT
> + /*
> + * Enable PCI Express Port0
> + */
> + reg = readl(KW_REG_CPU_CTRL_STAT);
> + reg |= (1 << 0); /* Set PEX0En Bit */
> + writel(reg, KW_REG_CPU_CTRL_STAT);
> +#endif
> + return 0;
> +}
> +#endif /* CONFIG_ARCH_CPU_INIT */
> diff --git a/include/asm-arm/config.h b/include/asm-arm/config.h
> index 049c44e..5d52f15 100644
> --- a/include/asm-arm/config.h
> +++ b/include/asm-arm/config.h
> @@ -21,4 +21,8 @@
> #ifndef _ASM_CONFIG_H_
> #define _ASM_CONFIG_H_
>
> +#if defined (CONFIG_KIRKWOOD)
> +#include <asm-arm/arch-kirkwood/kirkwood.h>
> +#endif /* CONFIG_KIRKWOOD */
a header must only be include in the file that need it
please remove from here
> +
> #endif
> diff --git a/include/common.h b/include/common.h
> index 30fff7d..9e4b859 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -294,6 +294,7 @@ void pciinfo (int, int);
> #endif
> #endif
>
> +int arch_misc_init (void);
please move to include/asm-arm/u-boot-arm.h
Best Regards,
J.
next prev parent reply other threads:[~2009-05-04 22:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 14:53 [U-Boot] [PATCH v6] Marvell Kirkwood family SOC support Prafulla Wadaskar
2009-05-04 22:08 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-04 22:38 ` Wolfgang Denk
2009-05-04 22:37 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-04 22:51 ` Wolfgang Denk
2009-05-05 6:11 ` Prafulla Wadaskar
2009-05-07 5:36 ` Prafulla Wadaskar
2009-05-05 6:28 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090504220837.GB13923@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.