From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Wed, 06 May 2009 23:20:44 +0200
Subject: [U-Boot] [PATCH 03/10] fec_imx27: driver for FEC ethernet
	controller on i.MX27
In-Reply-To: <1241634633-13917-4-git-send-email-yanok@emcraft.com>
References: <1241634633-13917-1-git-send-email-yanok@emcraft.com>
	<1241634633-13917-4-git-send-email-yanok@emcraft.com>
Message-ID: <20090506212044.D936683420E8@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Ilya,

In message <1241634633-13917-4-git-send-email-yanok@emcraft.com> you wrote:
> 
> --- /dev/null
> +++ b/drivers/net/fec_imx27.c
> +#include <asm/arch/clock.h>
> +#include <asm/arch/imx-regs.h>
> +#include <asm/io.h>
> +
> +#define CONFIG_PHY_ADDR	0

Ummm... "CONFIG_*" variables are by definition user changable, so they
get defined in board config files, but never in common C code.

[Lots of problematic code skipped as others already pointed out the
issues.]

> +int eth_init(bd_t * bd)
> +{
> +
> +	if (!once)
> +	{
> +		PRINTF("eth_init: fec_probe(bd)\n");
> +		fec_probe(bd);
> +		once = 1;
> +	}
> +	PRINTF("eth_init: fec_init(gfec.miiphy.edev, bd)\n");
> +	return fec_init(gfec.miiphy.edev, bd);
> +};

Incorrect brace style, also elsewhere.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You're dead, Jim.
	-- McCoy, "The Tholian Web", stardate unknown