From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760479AbZEHRQS (ORCPT ); Fri, 8 May 2009 13:16:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753606AbZEHRQD (ORCPT ); Fri, 8 May 2009 13:16:03 -0400 Received: from fg-out-1718.google.com ([72.14.220.157]:37629 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbZEHRQB (ORCPT ); Fri, 8 May 2009 13:16:01 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=HQZS4UkWenmyflqCt7j6TSQYXSu8711yljr3EyRQkBs6Wu/X5UlTNZPqQmo9yrQ4mp GwrLJk9G6Llq5lC5oUASkauwbA98hZCgbpDAjHDeWMpNtGQiHhiMNpJp2gq6sdJjoYCI xXWqY4af5aSds3SLel+9afsX6SgIHMKH1TNfI= Date: Fri, 8 May 2009 21:15:56 +0400 From: Cyrill Gorcunov To: "H. Peter Anvin" Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, vgoyal@redhat.com, hbabu@us.ibm.com, kexec@lists.infradead.org, ying.huang@intel.com, mingo@elte.hu, tglx@linutronix.de, ebiederm@xmission.com, sam@ravnborg.org Subject: Re: [PATCH 01/14] x86, boot: align the .bss section in the decompressor Message-ID: <20090508171556.GN6132@lenovo> References: <1241735222-6640-1-git-send-email-hpa@linux.intel.com> <1241735222-6640-2-git-send-email-hpa@linux.intel.com> <20090508075354.GA6132@lenovo> <4A0465E6.9000401@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A0465E6.9000401@zytor.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [H. Peter Anvin - Fri, May 08, 2009 at 10:03:34AM -0700] | Cyrill Gorcunov wrote: | > | | > | diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S | > | index 0d26c92..27c168d 100644 | > | --- a/arch/x86/boot/compressed/vmlinux.lds.S | > | +++ b/arch/x86/boot/compressed/vmlinux.lds.S | > | @@ -42,6 +42,7 @@ SECTIONS | > | *(.data.*) | > | _edata = . ; | > | } | > | + . = ALIGN(32); | > | .bss : { | > | _bss = . ; | > | *(.bss) | > | -- | > | 1.6.0.6 | > | | > | > Hi Peter, should not it be ALIGN(8) rather? I thought | > we keep these sections as tight as possible in a sake | > of limitation of setup code size. Perhaps I miss something. | > | | This isn't the setup code at all. This is the actual kernel, although | in its compressed form. Furthermore, this is the bss, so it doesn't | affect the compressed image size. | | -hpa | yeah, unfortunately I reveal that when my mail already gone. though I don't understand why 32 is there... could you please? -- Cyrill From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fg-out-1718.google.com ([72.14.220.156]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1M2Tg1-0005Lm-Uy for kexec@lists.infradead.org; Fri, 08 May 2009 17:16:09 +0000 Received: by fg-out-1718.google.com with SMTP id e21so544761fga.3 for ; Fri, 08 May 2009 10:16:00 -0700 (PDT) Date: Fri, 8 May 2009 21:15:56 +0400 From: Cyrill Gorcunov Subject: Re: [PATCH 01/14] x86, boot: align the .bss section in the decompressor Message-ID: <20090508171556.GN6132@lenovo> References: <1241735222-6640-1-git-send-email-hpa@linux.intel.com> <1241735222-6640-2-git-send-email-hpa@linux.intel.com> <20090508075354.GA6132@lenovo> <4A0465E6.9000401@zytor.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4A0465E6.9000401@zytor.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "H. Peter Anvin" Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, hbabu@us.ibm.com, ebiederm@xmission.com, ying.huang@intel.com, mingo@elte.hu, "H. Peter Anvin" , sam@ravnborg.org, tglx@linutronix.de, vgoyal@redhat.com [H. Peter Anvin - Fri, May 08, 2009 at 10:03:34AM -0700] | Cyrill Gorcunov wrote: | > | | > | diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S | > | index 0d26c92..27c168d 100644 | > | --- a/arch/x86/boot/compressed/vmlinux.lds.S | > | +++ b/arch/x86/boot/compressed/vmlinux.lds.S | > | @@ -42,6 +42,7 @@ SECTIONS | > | *(.data.*) | > | _edata = . ; | > | } | > | + . = ALIGN(32); | > | .bss : { | > | _bss = . ; | > | *(.bss) | > | -- | > | 1.6.0.6 | > | | > | > Hi Peter, should not it be ALIGN(8) rather? I thought | > we keep these sections as tight as possible in a sake | > of limitation of setup code size. Perhaps I miss something. | > | | This isn't the setup code at all. This is the actual kernel, although | in its compressed form. Furthermore, this is the bss, so it doesn't | affect the compressed image size. | | -hpa | yeah, unfortunately I reveal that when my mail already gone. though I don't understand why 32 is there... could you please? -- Cyrill _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec