From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Jan Beulich <jbeulich@novell.com>,
mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-64: improve e820_search_gap()
Date: Fri, 8 May 2009 22:53:47 +0200 [thread overview]
Message-ID: <20090508205347.GC23223@one.firstfloor.org> (raw)
In-Reply-To: <4A0492EA.6080403@zytor.com>
On Fri, May 08, 2009 at 01:15:38PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >"Jan Beulich" <jbeulich@novell.com> writes:
> >>Why blindly? Aren't hotpluggable memory ranges supposed to be reserved
> >>in the E820 map?
> >
> >They are supposed to be reserved in SRAT, but not in e820.
>
> Ah, okay. Perhaps we should fold this information into our internal
> "e820" map? If so I guess the question is how soon we can do that.
You could do that or just query SRAT too, but ...
The problem is really that there are still systems which have hidden
holes which are not reserved anywhere. When I last hacked on the gap algorithm
it triggered subtle bugs. So this will never be fully reliable.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-05-08 20:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 12:07 [PATCH] x86-64: improve e820_search_gap() Jan Beulich
2009-05-08 4:59 ` H. Peter Anvin
2009-05-08 6:40 ` Jan Beulich
2009-05-08 16:52 ` H. Peter Anvin
2009-05-08 19:22 ` Andi Kleen
2009-05-08 20:15 ` H. Peter Anvin
2009-05-08 20:53 ` Andi Kleen [this message]
2009-05-08 20:52 ` H. Peter Anvin
2009-05-09 10:00 ` Andi Kleen
2009-05-10 6:43 ` H. Peter Anvin
2009-05-10 15:18 ` Andi Kleen
2009-05-10 17:56 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2009-03-12 10:45 Jan Beulich
2009-03-12 11:02 ` Ingo Molnar
2009-03-12 11:31 ` Jan Beulich
2009-03-13 17:37 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090508205347.GC23223@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.