From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Date: Sun, 10 May 2009 20:51:40 +0200 Message-ID: <200905102051.41221.borntraeger@de.ibm.com> References: <20090508124821.GA3073@redhat.com> <200905101337.06836.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org, avi@redhat.com To: Rusty Russell Return-path: Received: from mtagate7.uk.ibm.com ([195.212.29.140]:59910 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944AbZEJSvn (ORCPT ); Sun, 10 May 2009 14:51:43 -0400 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate7.uk.ibm.com (8.14.3/8.13.8) with ESMTP id n4AIpiWm699968 for ; Sun, 10 May 2009 18:51:44 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4AIphuG3371206 for ; Sun, 10 May 2009 19:51:43 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4AIphZe013255 for ; Sun, 10 May 2009 19:51:43 +0100 In-Reply-To: <200905101337.06836.rusty@rustcorp.com.au> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: Am Sunday 10 May 2009 06:07:06 schrieb Rusty Russell: > Yes, and in fact a rough look at your patch reveals that we don't actually > need del_vq: now we track them, we can just do that as part of vdev > destruction, right? Some of my students are working on a test module for virtio. Its a driver that matches all virtio IDs which can be used via bind/unbind. We currently use del_vq/find_vq in non device_release code. I will recheck but my feeling is that I want to keep del_vq. Christian