From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Remis Lima Baima <remis.developer@googlemail.com>
Subject: Re: [PATCH v2] x86: fix ktermios-termio conversion
Date: Tue, 12 May 2009 11:05:27 +0100 [thread overview]
Message-ID: <20090512110527.5352cd0e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20090512092601.GB29796@elte.hu>
> My argument was very simple: the patch causes +150 bytes of bloat.
> The try/ex/catch method can help reduce register pressure and can
> reducethe size of code quite visibly.
My argument is even simpler - its not worth the effort in the first place.
I'm sure you could use the same time to shave 150 bytes and a few clocks
of a path that actually gets executed.
Arnd - can you send me a diff that keeps the existing horrible macro
version, the existing __put_user usage and just fixes c_line ? It's
worked for 15 years, its not worth the time being fancy with it.
Alan
next prev parent reply other threads:[~2009-05-12 10:06 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090511222702.352192505@arndb.de>
2009-05-11 22:37 ` [PATCH] mb862xxfb: use CONFIG_OF instead of CONFIG_PPC_OF Arnd Bergmann
2009-05-13 12:25 ` Anatolij Gustschin
2009-05-11 22:38 ` [PATCH] ata: libata depends on HAS_DMA Arnd Bergmann
2009-05-12 0:58 ` Jeff Garzik
2009-05-12 12:40 ` Arnd Bergmann
2009-05-12 13:05 ` Arnd Bergmann
2009-05-12 13:05 ` Arnd Bergmann
2009-05-12 8:06 ` Alan Cox
2009-05-12 9:23 ` Arnd Bergmann
2009-05-12 9:23 ` Arnd Bergmann
2009-05-13 3:30 ` Brad Boyer
2009-05-13 3:30 ` Brad Boyer
2009-05-13 4:12 ` Michael Schmitz
2009-05-13 4:12 ` Michael Schmitz
2009-05-13 4:12 ` Michael Schmitz
2009-05-13 4:34 ` Brad Boyer
2009-05-13 4:34 ` Brad Boyer
2009-05-13 8:51 ` Alan Cox
2009-05-13 8:55 ` Geert Uytterhoeven
2009-05-13 23:57 ` Robert Hancock
2009-05-14 0:18 ` FUJITA Tomonori
2009-05-15 5:31 ` Tejun Heo
2009-05-15 11:16 ` Arnd Bergmann
2009-05-15 11:16 ` Arnd Bergmann
2009-05-15 11:21 ` Tejun Heo
2009-05-15 11:55 ` Arnd Bergmann
2009-05-17 9:00 ` Robert Hancock
2009-05-17 19:38 ` Arnd Bergmann
2009-05-17 20:05 ` Jeff Garzik
2009-05-17 22:45 ` [PATCH] asm-generic: add a dma-mapping.h file Arnd Bergmann
2009-05-18 6:03 ` Geert Uytterhoeven
2009-05-18 6:03 ` Geert Uytterhoeven
2009-05-18 8:28 ` Arnd Bergmann
2009-05-18 10:45 ` FUJITA Tomonori
2009-05-18 14:45 ` Arnd Bergmann
2009-05-18 22:44 ` FUJITA Tomonori
2009-05-19 16:22 ` Arnd Bergmann
2009-05-19 17:01 ` Grant Grundler
2009-05-19 17:40 ` Arnd Bergmann
2009-05-19 18:08 ` Grant Grundler
2009-05-19 18:08 ` Grant Grundler
2009-05-22 12:12 ` FUJITA Tomonori
2009-05-22 14:07 ` Arnd Bergmann
2009-05-22 14:38 ` FUJITA Tomonori
2009-05-22 15:05 ` Arnd Bergmann
2009-05-26 4:36 ` FUJITA Tomonori
2009-05-26 12:35 ` Arnd Bergmann
2009-05-27 3:58 ` FUJITA Tomonori
2009-05-18 22:54 ` Jeff Garzik
2009-05-18 23:22 ` FUJITA Tomonori
2009-05-18 10:45 ` [PATCH] ata: libata depends on HAS_DMA FUJITA Tomonori
2009-05-13 10:39 ` Arnd Bergmann
2009-05-13 10:39 ` Arnd Bergmann
2009-05-13 10:39 ` Arnd Bergmann
2009-05-11 22:40 ` [PATCH] scsi: libsas " Arnd Bergmann
2009-05-11 22:50 ` James Bottomley
2009-05-11 22:59 ` James Bottomley
2009-05-11 23:16 ` Arnd Bergmann
2009-05-11 22:43 ` [PATCH] arm: rename CLOCK_TICK_RATE to ARM_TICK_RATE Arnd Bergmann
2009-05-11 23:11 ` [PATCH v2] " Arnd Bergmann
2009-05-13 17:11 ` [PATCH] " Arnd Bergmann
2009-05-11 22:50 ` [PATCH] x86: use PIT_TICK_RATE consistently Arnd Bergmann
2009-05-11 23:05 ` Arnd Bergmann
2009-05-11 22:55 ` [PATCH] move PIT_TICK_RATE to linux/timex.h Arnd Bergmann
2009-05-11 22:55 ` Arnd Bergmann
2009-05-12 0:01 ` Andrew Morton
2009-05-12 0:36 ` Arnd Bergmann
2009-05-11 22:57 ` [PATCH] mips: use PIT_TICK_RATE in i8253 Arnd Bergmann
2009-05-11 22:58 ` [PATCH] input: use PIT_TICK_RATE in vt beep ioctl Arnd Bergmann
2009-05-12 9:31 ` Alan Cox
2009-05-11 22:59 ` [PATCH] x86: fix ktermios-termio conversion Arnd Bergmann
2009-05-11 23:19 ` [PATCH v2] " Arnd Bergmann
2009-05-12 7:55 ` Ingo Molnar
2009-05-12 9:04 ` Arnd Bergmann
2009-05-12 9:10 ` Ingo Molnar
2009-05-12 9:21 ` Alan Cox
2009-05-12 9:26 ` Ingo Molnar
2009-05-12 10:05 ` Alan Cox [this message]
2009-05-12 10:15 ` Ingo Molnar
2009-05-12 11:33 ` [PATCH v3] " Arnd Bergmann
2009-05-12 11:42 ` [PATCH v2] " Arnd Bergmann
2009-05-12 9:17 ` Alan Cox
2009-05-11 23:02 ` [PATCH] ipc: use __ARCH_WANT_IPC_PARSE_VERSION in ipc/util.h Arnd Bergmann
2009-05-12 0:19 ` Serge E. Hallyn
2009-05-11 23:03 ` [PATCH] syscalls.h add the missing sys_pipe2 declaration Arnd Bergmann
2009-05-11 23:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512110527.5352cd0e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=remis.developer@googlemail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.