From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Date: Tue, 12 May 2009 18:33:30 +0300 Message-ID: <20090512153330.GB26883@redhat.com> References: <20090511221932.GA22915@redhat.com> <200905130000.03032.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christian Borntraeger , virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org, avi@redhat.com, Carsten Otte To: Rusty Russell Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41294 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbZELPfl (ORCPT ); Tue, 12 May 2009 11:35:41 -0400 Content-Disposition: inline In-Reply-To: <200905130000.03032.rusty@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 13, 2009 at 12:00:02AM +0930, Rusty Russell wrote: > On Tue, 12 May 2009 07:49:32 am Michael S. Tsirkin wrote: > > This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, > > and updates all drivers. This is needed for MSI support, because MSI > > needs to know the total number of vectors upfront. > > Sorry, is this not on top of my virtio_device vq linked list patch? Not yet, working on that. > Two other things: prefer vq_callback_t as the type name, ok > and perhaps consider > varargs for the callbacks (or would that be too horrible at the implementation > end?) > > Thanks, > Rusty. Ugh ... I think it will be. And AFAIK gcc generates a lot of code for varargs - not something we want to do in each interrupt handler. -- MST