From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: [PATCH] kvm: device-assignment: Fix kvm_get_irq_route_gsi() return check Date: Tue, 12 May 2009 16:14:01 -0600 Message-ID: <20090512221144.5883.46470.stgit@dl380g6-3.ned.telco.ned.telco> References: <20090507170834.26367.91907.stgit@dl380g6-3.ned.telco.ned.telco> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: sheng.yang@intel.com, alex.williamson@hp.com To: kvm@vger.kernel.org Return-path: Received: from g4t0015.houston.hp.com ([15.201.24.18]:30998 "EHLO g4t0015.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755362AbZELWN6 (ORCPT ); Tue, 12 May 2009 18:13:58 -0400 In-Reply-To: <20090507170834.26367.91907.stgit@dl380g6-3.ned.telco.ned.telco> Sender: kvm-owner@vger.kernel.org List-ID: Cast to a signed int to test for < 0. Signed-off-by: Alex Williamson --- This supersedes "[PATCH] kvm: device-assignment: Catch GSI overflow" hw/device-assignment.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index a6cc9b9..5bdae24 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -798,7 +798,7 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos) pci_dev->cap.start + PCI_MSI_DATA_32); assigned_dev->entry->type = KVM_IRQ_ROUTING_MSI; assigned_dev->entry->gsi = kvm_get_irq_route_gsi(kvm_context); - if (assigned_dev->entry->gsi < 0) { + if ((int)(assigned_dev->entry->gsi) < 0) { perror("assigned_dev_update_msi: kvm_get_irq_route_gsi"); return; }