From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations
Date: Tue, 12 May 2009 22:33:14 +0930
Message-ID: <200905122233.15099.rusty@rustcorp.com.au>
References: <cover.1241700929.git.mst@redhat.com> <200905101337.06836.rusty@rustcorp.com.au> <20090510072538.GA5335@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	virtualization@lists.linux-foundation.org,
	Anthony Liguori <anthony@codemonkey.ws>, kvm@vger.kernel.org,
	avi@redhat.com
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:59289 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751169AbZELND2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 May 2009 09:03:28 -0400
In-Reply-To: <20090510072538.GA5335@redhat.com>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 10 May 2009 04:55:38 pm Michael S. Tsirkin wrote:
> On Sun, May 10, 2009 at 01:37:06PM +0930, Rusty Russell wrote:
> > Yes, and in fact a rough look at your patch reveals that we don't
> > actually need del_vq: now we track them, we can just do that as part of
> > vdev destruction, right?
>
> Let's assume that a driver encounters an error in probe
> after it calls find_vq. It would need a way to revert
> find_vq, won't it?
>
> It seems to me that bus->remove does not get called
> on probe failure. Isn't that right?

Yep, I looked too fast.

Thanks,
Rusty.