From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Wed, 13 May 2009 00:51:14 +0200
Subject: [U-Boot] [PATCHv2 1/4] omap3: embedd gpmc_cs into gpmc
	config	struct
In-Reply-To: <e0063726a43c70a59b915fcd30c5333b2282ce7a.1242115589.git.mludwig@ultratronik.de>
References: <cover.1242115589.git.mludwig@ultratronik.de>
	<e0063726a43c70a59b915fcd30c5333b2282ce7a.1242115589.git.mludwig@ultratronik.de>
Message-ID: <20090512225114.GJ479@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10:12 Tue 12 May     , Matthias Ludwig wrote:
> Embedd chip select configuration into struct for gpmc config
> instead of having it completely separated as suggested by
> Wolfgang Denk on
> http://lists.denx.de/pipermail/u-boot/2009-May/052247.html
> 
> Attention: this also fixes a missnaming in board/omap3/evm/evm.c
> which told to use CS6 but used CS5 in reallity. More info on
> http://lists.denx.de/pipermail/u-boot/2009-May/052157.html
it will be better to split this in 2 patch
to bisect it
> 
> Signed-off-by: Matthias Ludwig <mludwig@ultratronik.de>
> ---
>  board/omap3/evm/evm.c             |   16 +++++++-------
>  cpu/arm_cortexa8/omap3/mem.c      |   33 ++++++++++++------------------
>  cpu/arm_cortexa8/omap3/sys_info.c |    4 +-
>  drivers/mtd/nand/omap_gpmc.c      |   22 ++++++-------------
>  include/asm-arm/arch-omap3/cpu.h  |   40 ++++++++++++++++--------------------
>  include/configs/omap3_beagle.h    |    1 -
>  include/configs/omap3_evm.h       |    1 -
>  include/configs/omap3_overo.h     |    1 -
>  include/configs/omap3_pandora.h   |    1 -
>  include/configs/omap3_zoom1.h     |    1 -
zoom2?
>  10 files changed, 48 insertions(+), 72 deletions(-)
> 
> diff --git a/board/omap3/evm/evm.c b/board/omap3/evm/evm.c
> index c008c2e..032c93a 100644
<snip>
>  
>  #ifndef __ASSEMBLY__
> +struct gpmc_cs {
> +	unsigned int config1;		/* 0x00 */
> +	unsigned int config2;		/* 0x04 */
> +	unsigned int config3;		/* 0x08 */
> +	unsigned int config4;		/* 0x0C */
> +	unsigned int config5;		/* 0x10 */
> +	unsigned int config6;		/* 0x14 */
> +	unsigned int config7;		/* 0x18 */
why not an array so can use a loop as in enable_gpmc_cs_config()
> +	unsigned int nand_cmd;		/* 0x1C */
> +	unsigned int nand_adr;		/* 0x20 */
> +	unsigned int nand_dat;		/* 0x24 */
> +	unsigned char res[8];		/* blow up to 0x30 byte */
> +};
> +
otherwise seam good

Best Regards,
J.