From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations Date: Wed, 13 May 2009 00:00:02 +0930 Message-ID: <200905130000.03032.rusty@rustcorp.com.au> References: <20090511221932.GA22915@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Christian Borntraeger , virtualization@lists.linux-foundation.org, Anthony Liguori , kvm@vger.kernel.org, avi@redhat.com, Carsten Otte To: "Michael S. Tsirkin" Return-path: Received: from ozlabs.org ([203.10.76.45]:47228 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbZELOaP (ORCPT ); Tue, 12 May 2009 10:30:15 -0400 In-Reply-To: <20090511221932.GA22915@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 12 May 2009 07:49:32 am Michael S. Tsirkin wrote: > This replaces find_vq/del_vq with find_vqs/del_vqs virtio operations, > and updates all drivers. This is needed for MSI support, because MSI > needs to know the total number of vectors upfront. Sorry, is this not on top of my virtio_device vq linked list patch? Two other things: prefer vq_callback_t as the type name, and perhaps consider varargs for the callbacks (or would that be too horrible at the implementation end?) Thanks, Rusty.