From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: tj@kernel.org
Cc: fujita.tomonori@lab.ntt.co.jp, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH 0/2] swim3: use blk_end_request_all()
Date: Wed, 13 May 2009 00:31:08 +0900 [thread overview]
Message-ID: <20090513003226E.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <4A0994FF.1030909@kernel.org>
On Wed, 13 May 2009 00:25:51 +0900
Tejun Heo <tj@kernel.org> wrote:
> Hello,
>
> FUJITA Tomonori wrote:
> > This is against for-2.6.31 branch in the block tree.
> >
> > Tejun, don't we need to use blk_end_request_all() when we hit the
> > maximum retry count in swim3_interrupt? Looks like we can't handle a
> > request properly if we doesn't complete the request there.
>
> Ummm.... why so? Can you elaborate the bug scenario a bit? I was
> trying to keep the original behavior whereever possible.
If when a request hits the maximum retry count and
swim3_end_request_cur() doesn't complete the request there, where the
request will be freed?
> > There are some other places to use blk_end_request_all if we need to.
>
> There are some other places where end_request_all can be used but I
> hope there isn't any place where we should but aren't. :-)
>
> Thanks.
>
> --
> tejun
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-05-12 15:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 11:29 [PATCH 0/2] swim3: use blk_end_request_all() FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request_all when we hit the maximum retry count FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request instead of blk_update_request FUJITA Tomonori
2009-05-12 14:45 ` Boaz Harrosh
2009-05-12 15:06 ` FUJITA Tomonori
2009-05-12 15:27 ` Tejun Heo
2009-05-13 0:50 ` Kiyoshi Ueda
2009-05-13 5:49 ` Jens Axboe
2009-05-13 5:52 ` Tejun Heo
2009-05-13 5:59 ` Jens Axboe
2009-05-12 15:25 ` [PATCH 0/2] swim3: use blk_end_request_all() Tejun Heo
2009-05-12 15:31 ` FUJITA Tomonori [this message]
2009-05-12 15:36 ` Tejun Heo
2009-05-12 15:51 ` FUJITA Tomonori
2009-05-12 22:58 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090513003226E.fujita.tomonori@lab.ntt.co.jp \
--to=fujita.tomonori@lab.ntt.co.jp \
--cc=benh@kernel.crashing.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.