From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: [PATCH v2] kvm: device-assignment: Fix kvm_get_irq_route_gsi() return check Date: Tue, 12 May 2009 22:45:11 -0600 Message-ID: <20090513044337.6737.29376.stgit@dl380g6-3.ned.telco.ned.telco> References: <20090512221144.5883.46470.stgit@dl380g6-3.ned.telco.ned.telco> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: sheng.yang@intel.com, alex.williamson@hp.com To: kvm@vger.kernel.org Return-path: Received: from g4t0015.houston.hp.com ([15.201.24.18]:11831 "EHLO g4t0015.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbZEMEpF (ORCPT ); Wed, 13 May 2009 00:45:05 -0400 In-Reply-To: <20090512221144.5883.46470.stgit@dl380g6-3.ned.telco.ned.telco> Sender: kvm-owner@vger.kernel.org List-ID: Use 'r' for the return value since gsi is unsigned. Signed-off-by: Alex Williamson --- v2: Use 'r' instead of a cast, per Sheng Yang hw/device-assignment.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index a6cc9b9..4107915 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -797,11 +797,12 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos) assigned_dev->entry->u.msi.data = *(uint16_t *)(pci_dev->config + pci_dev->cap.start + PCI_MSI_DATA_32); assigned_dev->entry->type = KVM_IRQ_ROUTING_MSI; - assigned_dev->entry->gsi = kvm_get_irq_route_gsi(kvm_context); - if (assigned_dev->entry->gsi < 0) { + r = kvm_get_irq_route_gsi(kvm_context); + if (r < 0) { perror("assigned_dev_update_msi: kvm_get_irq_route_gsi"); return; } + assigned_dev->entry->gsi = r; kvm_add_routing_entry(kvm_context, assigned_dev->entry); if (kvm_commit_irq_routes(kvm_context) < 0) {