From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 13 May 2009 07:26:55 +0200 Subject: [U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global In-Reply-To: <20090512230224.GL479@game.jcrosoft.org> References: <20090512230224.GL479@game.jcrosoft.org> Message-ID: <20090513052655.1A271832E416@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe PLAGNIOL-VILLARD, In message <20090512230224.GL479@game.jcrosoft.org> you wrote: > > diff --git a/cpu/arm_cortexa8/omap3/mem.c b/cpu/arm_cortexa8/omap3/mem.c > > index aa15f94..079c848 100644 > > --- a/cpu/arm_cortexa8/omap3/mem.c > > +++ b/cpu/arm_cortexa8/omap3/mem.c > > @@ -41,6 +41,8 @@ unsigned int boot_flash_sec; > > unsigned int boot_flash_type; > > volatile unsigned int boot_flash_env_addr; > > > > +struct gpmc *gpmc_cfg; > please do not expose it directly > please use a function to get it Isn't this just adding to the memory footprint for little or no benefit? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de EARTH smog | bricks AIR -- mud -- FIRE soda water | tequila WATER