From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Wed, 13 May 2009 09:04:48 +0200 Subject: [U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global In-Reply-To: <20090513052655.1A271832E416@gemini.denx.de> References: <20090512230224.GL479@game.jcrosoft.org> <20090513052655.1A271832E416@gemini.denx.de> Message-ID: <20090513070448.GD30859@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07:26 Wed 13 May , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090512230224.GL479@game.jcrosoft.org> you wrote: > > > diff --git a/cpu/arm_cortexa8/omap3/mem.c b/cpu/arm_cortexa8/omap3/mem.c > > > index aa15f94..079c848 100644 > > > --- a/cpu/arm_cortexa8/omap3/mem.c > > > +++ b/cpu/arm_cortexa8/omap3/mem.c > > > @@ -41,6 +41,8 @@ unsigned int boot_flash_sec; > > > unsigned int boot_flash_type; > > > volatile unsigned int boot_flash_env_addr; > > > > > > +struct gpmc *gpmc_cfg; > > please do not expose it directly > > please use a function to get it > > Isn't this just adding to the memory footprint for little or no > benefit? avoid overwrite of the pointer by never use it directly Best Regards, J.