From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Ludwig Date: Wed, 13 May 2009 09:16:46 +0200 Subject: [U-Boot] [PATCHv2 1/4] omap3: embedd gpmc_cs into gpmc config struct In-Reply-To: <20090512225114.GJ479@game.jcrosoft.org> References: <20090512225114.GJ479@game.jcrosoft.org> Message-ID: <20090513071646.GA15729@ultratronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe, > > Attention: this also fixes a missnaming in board/omap3/evm/evm.c > > which told to use CS6 but used CS5 in reallity. More info on > > http://lists.denx.de/pipermail/u-boot/2009-May/052157.html > it will be better to split this in 2 patch > to bisect it but how to split? I do not want to break the code (when only one of them applied). The pure renaming patch i sent last week was trigger for this series. > > board/omap3/evm/evm.c | 16 +++++++------- > > cpu/arm_cortexa8/omap3/mem.c | 33 ++++++++++++------------------ > > cpu/arm_cortexa8/omap3/sys_info.c | 4 +- > > drivers/mtd/nand/omap_gpmc.c | 22 ++++++------------- > > include/asm-arm/arch-omap3/cpu.h | 40 ++++++++++++++++-------------------- > > include/configs/omap3_beagle.h | 1 - > > include/configs/omap3_evm.h | 1 - > > include/configs/omap3_overo.h | 1 - > > include/configs/omap3_pandora.h | 1 - > > include/configs/omap3_zoom1.h | 1 - > zoom2? The patch then doess not apply on master... Which branch/repo should i base it on? > > #ifndef __ASSEMBLY__ > > +struct gpmc_cs { > > + unsigned int config1; /* 0x00 */ > > + unsigned int config2; /* 0x04 */ > > + unsigned int config3; /* 0x08 */ > > + unsigned int config4; /* 0x0C */ > > + unsigned int config5; /* 0x10 */ > > + unsigned int config6; /* 0x14 */ > > + unsigned int config7; /* 0x18 */ > why not an array so can use a loop as in enable_gpmc_cs_config() good idea, will be fixed. Thanks for review, Matthias -- Matthias Ludwig, Software Development Ultratronik Entwicklungs GmbH, Gewerbestrasse 52, 82211 Herrsching, Germany http://www.ultratronik.de Tel: +49 8152 3709-356 Fax: +49 8152 5183 Registergericht Muenchen, HRB 55584