From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Sheng" Subject: Re: [PATCH] kvm: device-assignment: Fix kvm_get_irq_route_gsi() return check Date: Wed, 13 May 2009 12:09:24 +0800 Message-ID: <200905131209.24578.sheng.yang@intel.com> References: <20090507170834.26367.91907.stgit@dl380g6-3.ned.telco.ned.telco> <200905131136.57555.sheng.yang@intel.com> <1242186950.4878.18.camel@2710p.home> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" To: Alex Williamson Return-path: Received: from mga01.intel.com ([192.55.52.88]:31403 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbZEMEIg (ORCPT ); Wed, 13 May 2009 00:08:36 -0400 In-Reply-To: <1242186950.4878.18.camel@2710p.home> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 13 May 2009 11:55:50 Alex Williamson wrote: > On Wed, 2009-05-13 at 11:36 +0800, Yang, Sheng wrote: > > On Wednesday 13 May 2009 06:14:01 Alex Williamson wrote: > > > --- a/hw/device-assignment.c > > > +++ b/hw/device-assignment.c > > > @@ -798,7 +798,7 @@ static void assigned_dev_update_msi(PCIDevice > > > *pci_dev, unsigned int ctrl_pos) pci_dev->cap.start + PCI_MSI_DATA_32); > > > assigned_dev->entry->type = KVM_IRQ_ROUTING_MSI; > > > assigned_dev->entry->gsi = kvm_get_irq_route_gsi(kvm_context); > > > - if (assigned_dev->entry->gsi < 0) { > > > + if ((int)(assigned_dev->entry->gsi) < 0) { > > > perror("assigned_dev_update_msi: kvm_get_irq_route_gsi"); > > > return; > > > } > > > > Use a return value(r) seems better. > > Hi Sheng, > > Do you mean: > > r = kvm_get_irq_route_gsi(kvm_context); > if (r < 0) { > ... > } > assigned_dev->entry->gsi = r; Yes. > > And I realized there is memory leak here. Entry seems haven't been freed > > for error... So does MSI-X... > > I hadn't noticed that one, but now that you mention it, yep. Thanks, Thanks. :) -- regards Yang, Sheng