From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Sheng" Subject: Re: [PATCH v2] kvm: device-assignment: Fix kvm_get_irq_route_gsi() =?utf-8?q?return=09check?= Date: Wed, 13 May 2009 12:58:17 +0800 Message-ID: <200905131258.18352.sheng.yang@intel.com> References: <20090512221144.5883.46470.stgit@dl380g6-3.ned.telco.ned.telco> <20090513044337.6737.29376.stgit@dl380g6-3.ned.telco.ned.telco> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" To: Alex Williamson Return-path: Received: from mga09.intel.com ([134.134.136.24]:16813 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbZEME5a (ORCPT ); Wed, 13 May 2009 00:57:30 -0400 In-Reply-To: <20090513044337.6737.29376.stgit@dl380g6-3.ned.telco.ned.telco> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 13 May 2009 12:45:11 Alex Williamson wrote: > Use 'r' for the return value since gsi is unsigned. > > Signed-off-by: Alex Williamson > --- Acked. -- regards Yang, Sheng > > v2: Use 'r' instead of a cast, per Sheng Yang > > hw/device-assignment.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index a6cc9b9..4107915 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -797,11 +797,12 @@ static void assigned_dev_update_msi(PCIDevice > *pci_dev, unsigned int ctrl_pos) assigned_dev->entry->u.msi.data = > *(uint16_t *)(pci_dev->config + pci_dev->cap.start + PCI_MSI_DATA_32); > assigned_dev->entry->type = KVM_IRQ_ROUTING_MSI; > - assigned_dev->entry->gsi = kvm_get_irq_route_gsi(kvm_context); > - if (assigned_dev->entry->gsi < 0) { > + r = kvm_get_irq_route_gsi(kvm_context); > + if (r < 0) { > perror("assigned_dev_update_msi: kvm_get_irq_route_gsi"); > return; > } > + assigned_dev->entry->gsi = r; > > kvm_add_routing_entry(kvm_context, assigned_dev->entry); > if (kvm_commit_irq_routes(kvm_context) < 0) {