All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Helt <krzysztof.h1@wp.pl>
To: linux-kbuild@vger.kernel.org
Cc: LKLM <linux-kernel@vger.kernel.org>
Subject: Kconfig: fix problem in HID menu
Date: Sun, 17 May 2009 17:56:17 +0200	[thread overview]
Message-ID: <20090517175617.81323cc1.krzysztof.h1@wp.pl> (raw)

From: Krzysztof Helt <krzysztof.h1@wp.pl>

Following syntax does not work properly if there is an options FOO2 depending on the FOO:

config FOO
	tristate "Foo" if EMBEDDED
	depends on FUD
	default !EMBEDDED

config FOO2
	bool "Foo2"
	depends on FOO

If the EMBEDDED is not selected the FOO option is selected
and it cannot be unselected.

The change of the FOO definition:

config FOO
	tristate "Foo" 
	depends on EMBEDDED && FUD
	default !EMBEDDED

fixes the issue.

This is likely a bug in Kconfig tool.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
---

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 7e67dcb..c52204d 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -153,8 +153,8 @@ config HID_KENSINGTON
 	Support for Kensington Slimblade Trackball.
 
 config HID_LOGITECH
-	tristate "Logitech" if EMBEDDED
-	depends on USB_HID
+	tristate "Logitech"
+	depends on EMBEDDED && USB_HID
 	default !EMBEDDED
 	---help---
 	Support for Logitech devices that are not fully compliant with HID standard.
@@ -205,8 +205,8 @@ config HID_NTRIG
 	Support for N-Trig touch screen.
 
 config HID_PANTHERLORD
-	tristate "Pantherlord devices support" if EMBEDDED
-	depends on USB_HID
+	tristate "Pantherlord devices support"
+	depends on EMBEDDED && USB_HID
 	default !EMBEDDED
 	---help---
 	Support for PantherLord/GreenAsia based device support.

             reply	other threads:[~2009-05-17 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17 15:56 Krzysztof Helt [this message]
2009-05-18  8:21 ` Kconfig: fix problem in HID menu Jiri Slaby
2009-05-18  8:49   ` Krzysztof Helt
2009-05-18  8:56     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090517175617.81323cc1.krzysztof.h1@wp.pl \
    --to=krzysztof.h1@wp.pl \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.