All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: rostedt@goodmis.org, mingo@elte.hu, tzanussi@gmail.com,
	jbaron@redhat.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing/events: Add timer and high res timer tracepoints
Date: Thu, 21 May 2009 22:38:10 +1000	[thread overview]
Message-ID: <20090521123810.GB23442@kryten> (raw)
In-Reply-To: <c62985530905201701i36527eblae479c07eec06515@mail.gmail.com>


Hi Frédéric,

> > +       ),
> > +
> > +       TP_fast_assign(
> > +               __entry->function = timer->function;
> > +       ),
> > +
> > +       TP_printk("func=%pF", __entry->function)
> 
> 
> Please use %pf which only prints the function name and ignore the
> offsets and so... These overload
> the trace in such case.

Thanks for the suggestion. It doesn't look like %pf has made Ingo's tree
yet, do you know if there is a plan to merge it soon?

Anton

  parent reply	other threads:[~2009-05-21 12:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20 10:13 [PATCH] tracing/events: Add timer and high res timer tracepoints Anton Blanchard
2009-05-20 10:25 ` KOSAKI Motohiro
2009-05-20 10:31 ` Thomas Gleixner
2009-05-21  0:01 ` Frédéric Weisbecker
2009-05-21  0:13   ` Steven Rostedt
2009-05-21 12:38   ` Anton Blanchard [this message]
2009-05-25 20:00     ` Frederic Weisbecker
2009-05-26  4:26 ` Anton Blanchard
2009-05-26  4:31   ` [PATCH] tracing/events: Rename worklet_execute to worklet_entry and worklet_complete to worklet_exit Anton Blanchard
2009-05-26  4:32     ` [PATCH] tracing/events: Use %pf in workqueue trace events Anton Blanchard
2009-05-26  4:36       ` tracing/events: Add tasklet tracepoints Anton Blanchard
2009-05-29 13:16     ` [PATCH] tracing/events: Rename worklet_execute to worklet_entry and worklet_complete to worklet_exit Frédéric Weisbecker
2009-05-26  4:55   ` [PATCH v3] tracing/events: Add timer and high res timer tracepoints Anton Blanchard
2009-05-26 18:06   ` [PATCH] " Frederic Weisbecker
2009-05-27  9:28     ` Xiao Guangrong
2009-05-27 14:22       ` Thomas Gleixner
2009-05-27 14:48         ` Frederic Weisbecker
2009-05-29  0:55           ` [PATCH] tracing/events: Add timer and high res timertracepoints Zhaolei
2009-05-27 13:46     ` [PATCH] tracing/events: Add timer and high res timer tracepoints Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090521123810.GB23442@kryten \
    --to=anton@samba.org \
    --cc=fweisbec@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.