From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751519AbZEVFtI (ORCPT ); Fri, 22 May 2009 01:49:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751085AbZEVFsz (ORCPT ); Fri, 22 May 2009 01:48:55 -0400 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:56653 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbZEVFsy (ORCPT ); Fri, 22 May 2009 01:48:54 -0400 Date: Fri, 22 May 2009 14:48:47 +0900 From: Paul Mundt To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH -next] v4l2: handle unregister for non-I2C builds Message-ID: <20090522054847.GB14059@linux-sh.org> Mail-Followup-To: Paul Mundt , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20090511161442.3e9d9cb9.sfr@canb.auug.org.au> <4A085455.5040108@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A085455.5040108@oracle.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 11, 2009 at 09:37:41AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Build fails when CONFIG_I2C=n, so handle that case in the if block: > > drivers/built-in.o: In function `v4l2_device_unregister': > (.text+0x157821): undefined reference to `i2c_unregister_device' > > Signed-off-by: Randy Dunlap This patch still has not been applied as far as I can tell, and builds are still broken as a result, almost 2 weeks after the fact. > --- > drivers/media/video/v4l2-device.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20090511.orig/drivers/media/video/v4l2-device.c > +++ linux-next-20090511/drivers/media/video/v4l2-device.c > @@ -85,6 +85,7 @@ void v4l2_device_unregister(struct v4l2_ > /* Unregister subdevs */ > list_for_each_entry_safe(sd, next, &v4l2_dev->subdevs, list) { > v4l2_device_unregister_subdev(sd); > +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) > if (sd->flags & V4L2_SUBDEV_FL_IS_I2C) { > struct i2c_client *client = v4l2_get_subdevdata(sd); > > @@ -95,6 +96,7 @@ void v4l2_device_unregister(struct v4l2_ > if (client) > i2c_unregister_device(client); > } > +#endif > } > } > EXPORT_SYMBOL_GPL(v4l2_device_unregister); > > > -- > ~Randy > LPC 2009, Sept. 23-25, Portland, Oregon > http://linuxplumbersconf.org/2009/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html