From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Sun, 24 May 2009 17:51:25 +0200 Subject: [U-Boot] [PATCHv2 4/4] omap3: use only fixed-size types inside ctrl_structs In-Reply-To: <20090513073227.GC15729@ultratronik.de> References: <54f934a823b4e02c5be4991744a0796570bd338d.1242115589.git.mludwig@ultratronik.de> <20090512230530.GM479@game.jcrosoft.org> <20090513073227.GC15729@ultratronik.de> Message-ID: <20090524155125.GM26561@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09:32 Wed 13 May , Matthias Ludwig wrote: > > > replace variable types in ctrl_structs for omap3 by those with > > > fixed size (u8, u16, u32). > > > Additional ifndef-protection is needed by examples which do not > > > compile when including asm/types.h > > could explain why and in which case we need it? > > Explain why transfor to fixed-size-types or explain why we need the > ifndef around all structs? > > The ifdef-protection against __KERNEL_STRICT_NAMES is needed to not break > code in the tools-dir which (implizitely) includes cpu.h. See this > compiler output: > > > gcc -g -Wall -idirafter /mdata/gsrc/u-boot/include -idirafter > > /mdata/gsrc/u-boot/include2 -idirafter /mdata/gsrc/u-boot/include -I > > /mdata/gsrc/u-boot/libfdt -I /mdata/gsrc/u-boot/tools > > -DTEXT_BASE=0x80e80000 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -O -c -o > > mkimage.o /mdata/gsrc/u-boot/tools/mkimage.c > > In file included from /mdata/gsrc/u-boot/include/configs/omap3_evm.h:46, > > from /mdata/gsrc/u-boot/include/config.h:2, > > from /mdata/gsrc/u-boot/include/command.h:30, > > from /mdata/gsrc/u-boot/include/image.h:55, > > from /mdata/gsrc/u-boot/tools/mkimage.c:26: > > /mdata/gsrc/u-boot/include/asm/arch/cpu.h:36: error: expected > > specifier-qualifier-list before ?u8? but why do you include it? this is the real problem Best Regards, J.