From: Andrew Morton <akpm@linux-foundation.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: sameo@linux.intel.com, holtmann@linux.intel.com,
yi.zhu@intel.com, linux-kernel@vger.kernel.org,
linville@tuxdriver.com, greg@kroah.com
Subject: Re: [PATCH] firmware: Allocate firmware id dynamically
Date: Tue, 26 May 2009 13:23:51 -0700 [thread overview]
Message-ID: <20090526132351.9805f1e8.akpm@linux-foundation.org> (raw)
In-Reply-To: <ac3eb2510905260711hb273541i8d69128b88933f7f@mail.gmail.com>
On Tue, 26 May 2009 16:11:35 +0200
Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Tue, May 26, 2009 at 16:04, Samuel Ortiz <sameo@linux.intel.com> wrote:
>
> > Since the firmware loader is not maintained by anyone, I'm sending this one to
> > you, for the next merge window:
>
> It's part of the driver-core directory, and handled by Greg.
To which it doesn't apply. It needed more fixes than I felt like making.
> > The firmware loader has a statically allocated 30 bytes long string for the
> > firmware id (a.k.a. the firmware file name). There is no reason why we couldnt
> > allocate dynamically, and avoid having restrictions on the firmware names
> > lengths.
>
> Looks good.
>
> > Please note that we have to keep the FIRMWARE_NAME_MAX definition around as
> > some drivers rely on it.
>
> I think the 6 files should be converted, and FIRMWARE_NAME_MAX
> removed, otherwise people will keep copying that crap around.
>
> drivers/pcmcia/ds.c
> drivers/usb/atm/ueagle-atm.c
> drivers/net/wireless/libertas/if_usb.c
> drivers/net/wireless/libertas/if_spi.c
> drivers/media/dvb/dvb-usb/dvb-usb.h
> drivers/media/common/tuners/tuner-xc2028.c
Yep.
next prev parent reply other threads:[~2009-05-26 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 14:04 [PATCH] firmware: Allocate firmware id dynamically Samuel Ortiz
2009-05-26 14:11 ` Kay Sievers
2009-05-26 20:23 ` Andrew Morton [this message]
2009-05-27 1:57 ` Stephen Rothwell
2009-05-27 8:17 ` Samuel Ortiz
2009-05-27 8:30 ` Kay Sievers
2009-05-27 15:04 ` Greg KH
2009-05-27 9:16 ` John W. Linville
2009-05-27 9:53 ` Samuel Ortiz
2009-05-27 6:19 ` Marcel Holtmann
2009-05-26 14:51 ` [PATCH] libertas: adapt for dynamic firmware id allocation John W. Linville
2009-05-26 17:02 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526132351.9805f1e8.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=holtmann@linux.intel.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sameo@linux.intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.