All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clocksource: SuperH TMU Timer driver
Date: Mon, 01 Jun 2009 10:57:48 +0000	[thread overview]
Message-ID: <20090601105747.GA32746@linux-sh.org> (raw)
In-Reply-To: <20090501065100.8800.99808.sendpatchset@rx1.opensource.se>

On Mon, Jun 01, 2009 at 07:50:40PM +0900, Magnus Damm wrote:
> 2009/5/30 Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>:
> > I made some investigation, and found that the warnings are printed
> > after zero value is set to TCOR. ?I checked SH7785 hardware manual,
> > but could not find any description what happens when zero value set
> > to TCOR.
> 
> Thanks for investigating. I read a few SH manuals before converting
> the old driver, but I couldn't find any description of zero value.
> Same as you.
> 
> The idea with zero value TCOR comes from the old driver. It may be
> there for some historical reason, or it may just be plain wrong. I've
> sometimes seen interrupt bursts with the old tmu driver which may be
> related.
> 
It was mostly there just because it worked and seemed like a reasonable
thing to do, and because no one had any better ideas on what to do in
that situation. But yes, technically the behaviour is undefined, and so
finding something slightly more precise is a good idea.

  parent reply	other threads:[~2009-06-01 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01  6:51 [PATCH] clocksource: SuperH TMU Timer driver Magnus Damm
2009-05-30 13:27 ` Shin-ichiro KAWASAKI
2009-06-01 10:50 ` Magnus Damm
2009-06-01 10:57 ` Paul Mundt [this message]
2009-06-01 22:37 ` Shin-ichiro KAWASAKI
2009-06-11 15:51 ` Shin-ichiro KAWASAKI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090601105747.GA32746@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.