All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Add generic bit operations
Date: Thu, 4 Jun 2009 20:00:42 +0200	[thread overview]
Message-ID: <20090604180042.GN26688@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090604115922.E6893832E416@gemini.denx.de>

On Thu, Jun 04, 2009 at 01:59:22PM +0200, Wolfgang Denk wrote:
> > And the functions I removed from asm-arm/bitops.h did that?
> 
> No. Let's be happy that we have eliminated some poor code, and if we
> add a replacement, let's make sure not to repeat the mistakes of the
> past again.

Ok. I just saw ubifs implementing its own set_bit() functions and
considered that the wrong place for such functions to live in. ext2
seems to do the same things, also minix. Platforms which want to
enable support for these filesystems have to do an evil #define to
map ext2_set_bit() to the platform specific version. Which is all
bogus, you might agree. And because of that situation, ubifs can't
currently build for anything else than ppc
(according to 'git grep -w fls include/asm*').

Hence I thought it might be a good idea (or at least a good start
thereof) to put the functions where I believe they belong to - a
'generic' place.

Anyway - applying the first patch of this series would at least prevent
others from being mislead by dead and wrong code.

Daniel

  parent reply	other threads:[~2009-06-04 18:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-04 10:27 [U-Boot] (no subject) Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 1/3] ARM: remove unused bit operations Daniel Mack
2009-06-04 10:27   ` [U-Boot] [PATCH 2/3] Add generic " Daniel Mack
2009-06-04 10:27     ` [U-Boot] [PATCH 3/3] ARM: add unaligned macros Daniel Mack
2009-06-04 17:42       ` Daniel Mack
2009-06-04 19:03         ` Wolfgang Denk
2009-06-04 19:23           ` Daniel Mack
2009-06-05  3:21             ` Stefan Roese
2009-06-04 11:45     ` [U-Boot] [PATCH 2/3] Add generic bit operations Wolfgang Denk
2009-06-04 11:48       ` Daniel Mack
2009-06-04 11:58         ` Wolfgang Denk
2009-06-04 11:47     ` Wolfgang Denk
2009-06-04 11:54       ` Daniel Mack
     [not found]         ` <20090604115922.E6893832E416@gemini.denx.de>
2009-06-04 18:00           ` Daniel Mack [this message]
2009-06-04 18:18             ` Stefan Roese
2009-06-04 19:06             ` Wolfgang Denk
2009-06-05 20:44     ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-07 22:41       ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090604180042.GN26688@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.