From: Sam Ravnborg <sam@ravnborg.org>
To: akpm@linux-foundation.org
Cc: linux-kbuild@vger.kernel.org, rpjday@crashcourse.ca, dwmw2@infradead.org
Subject: Re: [patch 3/3] scripts/headers_check.pl: correct RE in header CONFIG leak check
Date: Sat, 6 Jun 2009 00:14:54 +0200 [thread overview]
Message-ID: <20090605221454.GK29008@uranus.ravnborg.org> (raw)
In-Reply-To: <200905122102.n4CL2q6F007223@imap1.linux-foundation.org>
On Tue, May 12, 2009 at 01:43:36PM -0700, akpm@linux-foundation.org wrote:
> From: "Robert P. J. Day" <rpjday@crashcourse.ca>
>
> Correct the regular expression in scripts/headers_check.pl to include '_'
> as a valid character in the class; otherwise, the check will report a
> "leaked" symbol of CONFIG_A_B_C as merely CONFIG_A.
>
> This patch will make no difference whatsoever in the current kernel tree
> as the call to the perl routine that does that check is currently
> commented out:
>
> &check_include();
> &check_asm_types();
> &check_sizetypes();
> &check_prototypes();
> # Dropped for now. Too much noise &check_config();
>
> However, I noticed that problem when I was building the yum downloadable
> kernel source rpm for fedora 11 (beta), which *does* run that check, and
> that's where the problem became obvious.
Applied,
Sam
prev parent reply other threads:[~2009-06-05 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 20:43 [patch 3/3] scripts/headers_check.pl: correct RE in header CONFIG leak check akpm
2009-06-05 22:14 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605221454.GK29008@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.