From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Mack <daniel@caiaq.de>
Date: Mon, 8 Jun 2009 00:41:58 +0200
Subject: [U-Boot] [PATCH 2/3] Add generic bit operations
In-Reply-To: <20090605204421.GC25032@game.jcrosoft.org>
References: <1244111241-32735-1-git-send-email-daniel@caiaq.de>
	<1244111241-32735-2-git-send-email-daniel@caiaq.de>
	<1244111241-32735-3-git-send-email-daniel@caiaq.de>
	<20090605204421.GC25032@game.jcrosoft.org>
Message-ID: <20090607224158.GM26148@buzzloop.caiaq.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Jun 05, 2009 at 10:44:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > This adds generic bit operations for all platforms and enables includes
> > the implementations from asm-arm.
> > 
> > Code taken from Linux kernel.
> > 
> the __set_bit, __clear_bit, __change_bit & co generic is used on arm ok

Do you mean it worked before? Or are you referring to the version I
posted which you think is ok?

> but be aware that we use it in U-Boot so NACK

You use what? The functions I removed? I doubt that. The functions
marked 'external' have no implementation, and I also don't believe the
static inlines did the right thing (note the shift operations).

> and please do not rename __xxx by xxx they do not mean the same think
> 
> the __xxx can be re-ordered and the xxx not

Sorry, I don't get it - what's your point about the status quo in the
sources and about the patches?

Daniel