From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Wed, 10 Jun 2009 22:27:28 +0200 Subject: [U-Boot] [PATCH 3/4] ZOOM2 Add power reset button In-Reply-To: <7A436F7769CA33409C6B44B358BFFF0C0115CBB555@dlee02.ent.ti.com> References: <1244638432-30893-1-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-2-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-3-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-4-git-send-email-Tom.Rix@windriver.com> <4A2FD4BE.8050405@googlemail.com> <7A436F7769CA33409C6B44B358BFFF0C0115CBB3F9@dlee02.ent.ti.com> <1244651133.18811.2993.camel@localhost.localdomain> <7A436F7769CA33409C6B44B358BFFF0C0115CBB555@dlee02.ent.ti.com> Message-ID: <20090610202728.GD2080@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > How about this: > > Regarding Dirk's and Heiko's comment: > A) How about board/omap3/common/power.c to drivers/power/twl4030.c Ack but I've a patch for Dirk in my queued that I need to process about it so we have 2 choice 1) apply Dirk's patch first and the move the code to drivers/power 2) rewrite a patch against the next I've in mind to do the 1) to mention in the changelog Dirk's work > On patch [PATCH 2/4] I2C Add initial support for TWL4030: > B) introduce a new header in include/twl4030.h from Tom's patch > Remove drivers/i2c/twl4030_i2c.c from the patch instead add: > #define TWLL4030_READ_U8(MODULE, VAL,REG)\ > i2c_read((MODULE), (REG), 1, (VAL), 1) > #define TWLL4030_WRITE_U8(MODULE, VAL,REG)\ > i2c_read((MODULE), (REG), 1, (VAL), 1) > to include/twl4030.h in the patch. please use inline function for this Best Regards, J.