All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
@ 2009-06-14  6:52 Wu Zhangjin
  2009-06-14 12:34 ` Frederic Weisbecker
  2009-06-15 18:13 ` [tip:tracing/urgent] " tip-bot for Wu Zhangjin
  0 siblings, 2 replies; 3+ messages in thread
From: Wu Zhangjin @ 2009-06-14  6:52 UTC (permalink / raw)
  To: Frederic Weisbecker, linux-kernel, Linux-MIPS
  Cc: Steven Rostedt, Ralf Baechle, Pekka Enberg, Wu Zhangjin

From: Wu Zhangjin <wuzj@lemote.com>

when compiling linux-mips with kmemtrace enabled, there will be an
error:

include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
				a function)

I checked the source code and found trace_seq.h used PAGE_SIZE but not
included the relative header file, so, fix it via adding the header file
<asm/page.h>

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
---
 include/linux/trace_seq.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@
 
 #include <linux/fs.h>
 
+#include <asm/page.h>
+
 /*
  * Trace sequences are used to allow a function to call several other functions
  * to create a string of data to use (up to a max of PAGE_SIZE.
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
  2009-06-14  6:52 [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h Wu Zhangjin
@ 2009-06-14 12:34 ` Frederic Weisbecker
  2009-06-15 18:13 ` [tip:tracing/urgent] " tip-bot for Wu Zhangjin
  1 sibling, 0 replies; 3+ messages in thread
From: Frederic Weisbecker @ 2009-06-14 12:34 UTC (permalink / raw)
  To: Wu Zhangjin
  Cc: linux-kernel, Linux-MIPS, Steven Rostedt, Ralf Baechle,
	Pekka Enberg, Wu Zhangjin, Ingo Molnar

On Sun, Jun 14, 2009 at 02:52:30PM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
> 
> when compiling linux-mips with kmemtrace enabled, there will be an
> error:
> 
> include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> 				a function)
> 
> I checked the source code and found trace_seq.h used PAGE_SIZE but not
> included the relative header file, so, fix it via adding the header file
> <asm/page.h>
> 
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> Signed-off-by: Wu Zhangjin <wuzj@lemote.com>


Acked-by: Frederic Weisbecker <fweisbec@gmail.com>


> ---
>  include/linux/trace_seq.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
> index c68bccb..c134dd1 100644
> --- a/include/linux/trace_seq.h
> +++ b/include/linux/trace_seq.h
> @@ -3,6 +3,8 @@
>  
>  #include <linux/fs.h>
>  
> +#include <asm/page.h>
> +
>  /*
>   * Trace sequences are used to allow a function to call several other functions
>   * to create a string of data to use (up to a max of PAGE_SIZE.
> -- 
> 1.6.0.4
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:tracing/urgent] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
  2009-06-14  6:52 [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h Wu Zhangjin
  2009-06-14 12:34 ` Frederic Weisbecker
@ 2009-06-15 18:13 ` tip-bot for Wu Zhangjin
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Wu Zhangjin @ 2009-06-15 18:13 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, penberg, fweisbec, rostedt, tglx, wuzj

Commit-ID:  78be6914cb5c6d648617c51bb99bf81f28471d89
Gitweb:     http://git.kernel.org/tip/78be6914cb5c6d648617c51bb99bf81f28471d89
Author:     Wu Zhangjin <wuzj@lemote.com>
AuthorDate: Sun, 14 Jun 2009 14:52:30 +0800
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Mon, 15 Jun 2009 11:37:09 -0400

tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h

when compiling linux-mips with kmemtrace enabled, there will be an
error:

include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
				a function)

I checked the source code and found trace_seq.h used PAGE_SIZE but not
included the relative header file, so, fix it via adding the header file
<asm/page.h>

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
LKML-Reference: <1244962350-28702-1-git-send-email-wuzhangjin@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>


---
 include/linux/trace_seq.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@
 
 #include <linux/fs.h>
 
+#include <asm/page.h>
+
 /*
  * Trace sequences are used to allow a function to call several other functions
  * to create a string of data to use (up to a max of PAGE_SIZE.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-06-15 18:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-14  6:52 [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h Wu Zhangjin
2009-06-14 12:34 ` Frederic Weisbecker
2009-06-15 18:13 ` [tip:tracing/urgent] " tip-bot for Wu Zhangjin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.