All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benjamin S." <sbenni@gmx.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, js@sig21.net,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: 2.6.30 enabling cpu1 on resume fails after suspend to memory
Date: Sun, 14 Jun 2009 14:37:08 +0200	[thread overview]
Message-ID: <20090614143708.32ec250c@pluto-lenny.milky.way> (raw)
In-Reply-To: <200906141415.16949.rjw@sisk.pl>

On Sun, 14 Jun 2009 14:15:16 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Sunday 14 June 2009, Thomas Gleixner wrote:
> > On Sun, 14 Jun 2009, Rafael J. Wysocki wrote:
> > > Evidently, the change of the interrupt handling during suspend-resume,
> > > commit 2ed8d2b3a81bdbb0418301628ccdb008ac9f40b7 (PM: Rework handling of
> > > interrupts during suspend-resume) broke resume (specifically, the enabling of
> > > nonboot CPUs) on the Benjamin's machine, but only if MSI support is enabled.
> > > Also, resume works if suspend_device_irqs() and resume_device_irqs() in
> > > drivers/base/power/main.c are commented out.
> > > 
> > > Is there anything the MSI code does in __enable_irq() and/or __disable_irq()
> > > that might cause this problem to appear?
> > 
> > Not that I'm aware of. Which of the devices is using MSI ? Have to
> > tried to skip only the MSI ones in suspend/resume_device_irqs() ?
> 
> Good idea.
> 
> Benjamin, please send /proc/interrupts from your system.

I guess it does not matter if from 2.6.29.2 or from 2.6.30. This 
is from 2.6.29.2 with CONFIG_PCI_MSI set:

           CPU0       CPU1       
  0:         42          1   IO-APIC-edge      timer
  1:          0         81   IO-APIC-edge      i8042
  6:          0          5   IO-APIC-edge      floppy
  8:          0          1   IO-APIC-edge      rtc0
  9:          0          0   IO-APIC-fasteoi   acpi
 14:          0        328   IO-APIC-edge      ide0
 15:          0          0   IO-APIC-edge      ide1
 16:          2        408   IO-APIC-fasteoi   ohci_hcd:usb1, ohci_hcd:usb3, HDA Intel
 17:          0          3   IO-APIC-fasteoi   ehci_hcd:usb2
 18:          0          0   IO-APIC-fasteoi   ohci_hcd:usb5, ohci_hcd:usb6, ohci_hcd:usb7
 19:          0         17   IO-APIC-fasteoi   ehci_hcd:usb4, HDA Intel
 24:       4830          0  HPET_MSI-edge      hpet2
 26:          0        135   PCI-MSI-edge      eth0
 27:          0       2855   PCI-MSI-edge      ahci
NMI:          0          0   Non-maskable interrupts
LOC:         42       5070   Local timer interrupts
RES:       2634       2170   Rescheduling interrupts
CAL:         72        104   Function call interrupts
TLB:        367        198   TLB shootdowns
TRM:          0          0   Thermal event interrupts
THR:          0          0   Threshold APIC interrupts
SPU:          0          0   Spurious interrupts
ERR:          0
MIS:          0

I am going to compile 2.6.30 with CONFIG_PCI_MSI again to ensure 
it is the same, but that will take some time.


Benjamin

  parent reply	other threads:[~2009-06-14 12:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-14 10:09 2.6.30 enabling cpu1 on resume fails after suspend to memory Benjamin S.
2009-06-14 10:35 ` Rafael J. Wysocki
2009-06-14 10:57   ` Benjamin S.
2009-06-14 11:19     ` Rafael J. Wysocki
2009-06-14 11:48       ` Benjamin S.
2009-06-14 12:00         ` Rafael J. Wysocki
2009-06-14 12:09           ` Thomas Gleixner
2009-06-14 12:09           ` Thomas Gleixner
2009-06-14 12:15             ` Rafael J. Wysocki
2009-06-14 12:15             ` Rafael J. Wysocki
2009-06-14 12:37               ` Benjamin S.
2009-06-14 12:37               ` Benjamin S. [this message]
2009-06-14 12:43                 ` Thomas Gleixner
2009-06-14 12:43                 ` Thomas Gleixner
2009-06-14 12:59                   ` Benjamin S.
2009-06-14 13:05                     ` Thomas Gleixner
2009-06-14 13:05                     ` Thomas Gleixner
2009-06-14 13:35                       ` Benjamin S.
2009-06-14 13:35                       ` Benjamin S.
2009-06-14 12:59                   ` Benjamin S.
2009-06-14 12:46                 ` Thomas Gleixner
2009-06-14 12:46                 ` Thomas Gleixner
2009-06-14 13:12                   ` Pallipadi, Venkatesh
2009-06-14 13:17                     ` Thomas Gleixner
2009-06-14 13:26                       ` Pallipadi, Venkatesh
2009-06-14 13:49                         ` Thomas Gleixner
2009-06-14 13:49                         ` Thomas Gleixner
2009-06-14 14:45                           ` Thomas Gleixner
2009-06-14 15:03                             ` Benjamin S.
2009-06-14 15:03                             ` Benjamin S.
2009-06-14 15:41                               ` Thomas Gleixner
2009-06-14 15:41                               ` Thomas Gleixner
2009-06-14 16:12                                 ` Greg KH
2009-06-14 16:12                                 ` Greg KH
2009-06-14 16:19                                   ` Thomas Gleixner
2009-06-14 16:19                                   ` Thomas Gleixner
2009-06-15 13:12                               ` Johannes Stezenbach
2009-06-15 13:12                               ` Johannes Stezenbach
2009-06-14 14:45                           ` Thomas Gleixner
2009-06-14 13:17                     ` Thomas Gleixner
2009-06-14 12:00         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090614143708.32ec250c@pluto-lenny.milky.way \
    --to=sbenni@gmx.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=js@sig21.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.