From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761857AbZFNTFk (ORCPT ); Sun, 14 Jun 2009 15:05:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756650AbZFNTFc (ORCPT ); Sun, 14 Jun 2009 15:05:32 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:42106 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755131AbZFNTFc (ORCPT ); Sun, 14 Jun 2009 15:05:32 -0400 Date: Sun, 14 Jun 2009 21:05:33 +0200 From: Wolfram Sang To: "Hans J. Koch" Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org, Magnus Damm , Greg KH Subject: Re: [PATCH 2/2] uio: add an of_genirq driver Message-ID: <20090614190533.GA7387@pengutronix.de> References: <1244765062-14144-1-git-send-email-w.sang@pengutronix.de> <1244765062-14144-3-git-send-email-w.sang@pengutronix.de> <20090614122136.GD3639@local> <20090614171406.GA1010@pengutronix.de> <20090614183357.GE3639@local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline In-Reply-To: <20090614183357.GE3639@local> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: wsa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Anyway, 0 is a valid IRQ number, so it cannot be used as "no irq". May I point you to this thread? http://lkml.org/lkml/2005/11/21/221 (The issue comes up once in a while as some archs still use NO_IRQ, some wi= th 0 some with -1) > > if (uioinfo->irq =3D=3D NO_IRQ) > > uioinfo->irq =3D UIO_IRQ_NONE; >=20 > Sorry for my ignorance, but what is NO_IRQ? If I do a >=20 > grep -r NO_IRQ include/ >=20 > I get nothing. Try a 'cd arch' before that :) > Well, you claim it's a false positive. So far, you did not get any respon= ses, > AFAICS. I tend to agree with you, but I'd like to avoid patches that don't > pass checkpatch.pl, whatever the reason. Either the false positive gets > confirmed and fixed, or you should fix your patch. Well, I assume that issues regarding checkpatch do not have the highest priority (especially while the merge-window is open), which is understandab= le. Fixing this bug (I take any bets that this is one ;)) might not be so trivi= al, as modifying $Attributes can easily have lots of side-effects. Now, all this does not matter much, as the objections Grant raised are valid and there might be a totally different outcome to bind devices to UIO. But = at least, we have some code to discuss... Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAko1Sf0ACgkQD27XaX1/VRswpQCdGQOTi6H0+gDFHCh4zv4gTHiu JC4Ani63yA5RggVHZtl+yhwY4TdQpdB1 =KDm0 -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 2/2] uio: add an of_genirq driver Date: Sun, 14 Jun 2009 21:05:33 +0200 Message-ID: <20090614190533.GA7387@pengutronix.de> References: <1244765062-14144-1-git-send-email-w.sang@pengutronix.de> <1244765062-14144-3-git-send-email-w.sang@pengutronix.de> <20090614122136.GD3639@local> <20090614171406.GA1010@pengutronix.de> <20090614183357.GE3639@local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1593928681==" Return-path: In-Reply-To: <20090614183357.GE3639@local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: "Hans J. Koch" Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Magnus Damm , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg KH List-Id: devicetree@vger.kernel.org --===============1593928681== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Anyway, 0 is a valid IRQ number, so it cannot be used as "no irq". May I point you to this thread? http://lkml.org/lkml/2005/11/21/221 (The issue comes up once in a while as some archs still use NO_IRQ, some wi= th 0 some with -1) > > if (uioinfo->irq =3D=3D NO_IRQ) > > uioinfo->irq =3D UIO_IRQ_NONE; >=20 > Sorry for my ignorance, but what is NO_IRQ? If I do a >=20 > grep -r NO_IRQ include/ >=20 > I get nothing. Try a 'cd arch' before that :) > Well, you claim it's a false positive. So far, you did not get any respon= ses, > AFAICS. I tend to agree with you, but I'd like to avoid patches that don't > pass checkpatch.pl, whatever the reason. Either the false positive gets > confirmed and fixed, or you should fix your patch. Well, I assume that issues regarding checkpatch do not have the highest priority (especially while the merge-window is open), which is understandab= le. Fixing this bug (I take any bets that this is one ;)) might not be so trivi= al, as modifying $Attributes can easily have lots of side-effects. Now, all this does not matter much, as the objections Grant raised are valid and there might be a totally different outcome to bind devices to UIO. But = at least, we have some code to discuss... Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAko1Sf0ACgkQD27XaX1/VRswpQCdGQOTi6H0+gDFHCh4zv4gTHiu JC4Ani63yA5RggVHZtl+yhwY4TdQpdB1 =KDm0 -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL-- --===============1593928681== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org https://ozlabs.org/mailman/listinfo/devicetree-discuss --===============1593928681==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id C4607B7104 for ; Mon, 15 Jun 2009 05:05:40 +1000 (EST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [92.198.50.35]) by ozlabs.org (Postfix) with ESMTP id 4B022DDD0B for ; Mon, 15 Jun 2009 05:05:40 +1000 (EST) Date: Sun, 14 Jun 2009 21:05:33 +0200 From: Wolfram Sang To: "Hans J. Koch" Subject: Re: [PATCH 2/2] uio: add an of_genirq driver Message-ID: <20090614190533.GA7387@pengutronix.de> References: <1244765062-14144-1-git-send-email-w.sang@pengutronix.de> <1244765062-14144-3-git-send-email-w.sang@pengutronix.de> <20090614122136.GD3639@local> <20090614171406.GA1010@pengutronix.de> <20090614183357.GE3639@local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" In-Reply-To: <20090614183357.GE3639@local> Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org, linux-kernel@vger.kernel.org, Greg KH List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Anyway, 0 is a valid IRQ number, so it cannot be used as "no irq". May I point you to this thread? http://lkml.org/lkml/2005/11/21/221 (The issue comes up once in a while as some archs still use NO_IRQ, some wi= th 0 some with -1) > > if (uioinfo->irq =3D=3D NO_IRQ) > > uioinfo->irq =3D UIO_IRQ_NONE; >=20 > Sorry for my ignorance, but what is NO_IRQ? If I do a >=20 > grep -r NO_IRQ include/ >=20 > I get nothing. Try a 'cd arch' before that :) > Well, you claim it's a false positive. So far, you did not get any respon= ses, > AFAICS. I tend to agree with you, but I'd like to avoid patches that don't > pass checkpatch.pl, whatever the reason. Either the false positive gets > confirmed and fixed, or you should fix your patch. Well, I assume that issues regarding checkpatch do not have the highest priority (especially while the merge-window is open), which is understandab= le. Fixing this bug (I take any bets that this is one ;)) might not be so trivi= al, as modifying $Attributes can easily have lots of side-effects. Now, all this does not matter much, as the objections Grant raised are valid and there might be a totally different outcome to bind devices to UIO. But = at least, we have some code to discuss... Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAko1Sf0ACgkQD27XaX1/VRswpQCdGQOTi6H0+gDFHCh4zv4gTHiu JC4Ani63yA5RggVHZtl+yhwY4TdQpdB1 =KDm0 -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--