All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@infradead.org>
To: Minoru Usui <usui@mxm.nes.nec.co.jp>
Cc: 김재열 <gauri@etri.re.kr>,
	netdev@vger.kernel.org, containers@lists.linux-foundation.org
Subject: Re: [HELP] for using class group classifier network controller
Date: Mon, 15 Jun 2009 06:30:20 -0400	[thread overview]
Message-ID: <20090615103020.GA8894@bombadil.infradead.org> (raw)
In-Reply-To: <20090615113609.db5c0613.usui@mxm.nes.nec.co.jp>

On Mon, Jun 15, 2009 at 11:36:09AM +0900, Minoru Usui wrote:
> Hi, Cheiyol
> 
> > # classid 1:10
> > 
> > echo 0x1000A > /dev/cpuctl/foo/net_cls.classid
> > 
> > #classid 1:20
> > 
> > echo 0x10014 > /dev/cpuctl/bob/net_cls.classid
> 
> (snip)
> 
> > # add class 1:10 for foo group
> > 
> > $TC class add dev eth0 parent 1:0 classid 1:10 htb rate 50mbit
> > 
> > # add class 1:20 for bob group
> > 
> > $TC class add dev eth0 parent 1:0 classid 1:20 htb rate 30mbit
> > 
> > # default class
> > 
> > $TC class add dev eth0 parent 1:0 classid 1:30 htb rate 10mbit
> 
> In class ID to use TC, both a major number and a minor number are hexadecimal.
> So 1:10 equals 0x00010010.
> 
> I think, you should set 0x10010 to net_cls.classid if you classify to 1:10.

That's right, both net_cls.classid and tc use integers in hexadecimal form
for both, printing and parsing.

10:10 -> 0x100010
10:20 -> 0x100020

This seems to be the weak point regarding usability that's why I like
Minoru Usui's patch so much. It would no longer be necessary to really
understand the internals of classids etc.

  reply	other threads:[~2009-06-15 10:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15  0:56 [HELP] for using class group classifier network controller 김재열
2009-06-15  0:56 ` 김재열
2009-06-15  2:36 ` Minoru Usui
2009-06-15 10:30   ` Thomas Graf [this message]
     [not found]     ` <20090615103020.GA8894-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2009-06-22 18:05       ` [Devel] " Paul Menage
2009-06-22 18:05     ` Paul Menage
     [not found]   ` <20090615113609.db5c0613.usui-vEbCzmPPqHe45+QrQBaojngSJqDPrsil@public.gmane.org>
2009-06-15 10:30     ` Thomas Graf
2009-06-15  2:36 ` Minoru Usui
     [not found] <9f8101c9ed80$b730b830$8310fe81@etri.info>
     [not found] ` <9f8101c9ed80$b730b830$8310fe81-tRM8rG9f+DVhl2p70BpVqQ@public.gmane.org>
2009-06-15  8:18   ` Minoru Usui
2009-06-15  8:18 ` Minoru Usui
     [not found] <d89801c9ef32$cdfcf480$8310fe81@etri.info>
     [not found] ` <d89801c9ef32$cdfcf480$8310fe81-tRM8rG9f+DVhl2p70BpVqQ@public.gmane.org>
2009-06-18  4:13   ` Minoru Usui
2009-06-18  4:13 ` Minoru Usui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090615103020.GA8894@bombadil.infradead.org \
    --to=tgraf@infradead.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=gauri@etri.re.kr \
    --cc=netdev@vger.kernel.org \
    --cc=usui@mxm.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.