From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Greg KH <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Magnus Damm <damm@igel.co.jp>,
linux-pm@lists.linux-foundation.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch update] PM: Introduce core framework for run-time PM of I/O devices
Date: Mon, 15 Jun 2009 22:02:30 +0200 [thread overview]
Message-ID: <200906152202.32094.rjw__39423.4998304912$1245096166$gmane$org@sisk.pl> (raw)
In-Reply-To: <20090614161850.01435082@infradead.org>
On Monday 15 June 2009, Arjan van de Ven wrote:
> On Mon, 15 Jun 2009 00:57:31 +0200
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > On Sunday 14 June 2009, Rafael J. Wysocki wrote:
> > > On Sunday 14 June 2009, Rafael J. Wysocki wrote:
> > > > Hi,
> > > >
> > > > Below is the current version of my "run-time PM for I/O devices"
> > > > patch.
> > > >
> > > > I've done my best to address the comments received during the
> > > > recent discussions, but at the same time I've tried to make the
> > > > patch only contain the most essential things. For this reason,
> > > > for example, the sysfs interface is not there and it's going to
> > > > be added in a separate patch.
> > > >
> > > > Please let me know if you want me to change anything in this
> > > > patch or to add anything new to it. [Magnus, I remember you
> > > > wanted something like ->runtime_wakeup() along with
> > > > ->runtime_idle(), but I'm not sure it's really necessary. Please
> > > > let me know if you have any particular usage scenario for it.]
> >
> > Appended is an update of the patch addressing the today's comments
> > from Magnus.
>
> few comments from me
>
> 1) For the usecases for upcoming hw from Intel (where you really can't talk to the hw while it's in powersave mode); the locking needs to be
> IRQ safe. Think of it like this:
> Lets assume you get a (shared) interrupt from your device. In the handler you need to make 100% sure that
> 1) you're not suspended at this point .. basically do a forced wakeup right there and then
> 2) assure that you're not about to suspend
Does it mean we need to use spin_[un]lock_irq[save|restore]() everywhere in the
framework?
> 2) You use jiffies in the API; I would suggest exposing milliseconds instead and internally convert to jiffies;
> milliseconds tends to be a much more natural unit for this sort of thing
OK
Best,
Rafael
next prev parent reply other threads:[~2009-06-15 20:02 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 22:23 [PATCH] PM: Introduce core framework for run-time PM of I/O devices Rafael J. Wysocki
2009-06-14 9:41 ` Magnus Damm
2009-06-14 9:41 ` Magnus Damm
2009-06-14 9:41 ` Magnus Damm
2009-06-14 10:29 ` Rafael J. Wysocki
2009-06-14 10:29 ` Rafael J. Wysocki
2009-06-14 9:58 ` [linux-pm] " Rafael J. Wysocki
2009-06-14 22:57 ` [patch update] " Rafael J. Wysocki
2009-06-14 23:18 ` Arjan van de Ven
2009-06-15 20:02 ` Rafael J. Wysocki
2009-06-15 20:02 ` Rafael J. Wysocki [this message]
2009-06-14 23:18 ` Arjan van de Ven
2009-06-15 21:08 ` Alan Stern
2009-06-15 21:08 ` Alan Stern
2009-06-15 21:08 ` Alan Stern
2009-06-15 23:21 ` Rafael J. Wysocki
2009-06-16 14:30 ` Alan Stern
2009-06-16 14:30 ` Alan Stern
2009-06-16 14:30 ` Alan Stern
2009-06-16 21:30 ` [patch update 2] " Rafael J. Wysocki
2009-06-16 21:30 ` Rafael J. Wysocki
2009-06-16 22:33 ` [patch update 2 fix] " Rafael J. Wysocki
2009-06-17 20:08 ` Alan Stern
2009-06-17 20:08 ` Alan Stern
2009-06-17 23:07 ` Rafael J. Wysocki
2009-06-18 18:17 ` Alan Stern
2009-06-18 18:17 ` Alan Stern
2009-06-18 18:17 ` Alan Stern
2009-06-19 0:38 ` Rafael J. Wysocki
2009-06-19 0:38 ` Rafael J. Wysocki
2009-06-19 16:25 ` Alan Stern
2009-06-19 16:25 ` Alan Stern
2009-06-19 16:25 ` Alan Stern
2009-06-19 22:42 ` Rafael J. Wysocki
2009-06-20 2:34 ` Alan Stern
2009-06-20 2:34 ` Alan Stern
2009-06-20 2:34 ` Alan Stern
2009-06-20 14:30 ` Alan Stern
2009-06-20 14:30 ` [linux-pm] " Alan Stern
2009-06-20 23:48 ` Rafael J. Wysocki
2009-06-20 23:48 ` [linux-pm] " Rafael J. Wysocki
2009-06-21 2:30 ` Alan Stern
2009-06-21 2:30 ` [linux-pm] " Alan Stern
2009-06-21 11:32 ` Rafael J. Wysocki
2009-06-21 11:32 ` [linux-pm] " Rafael J. Wysocki
2009-06-22 14:16 ` Alan Stern
2009-06-22 15:27 ` Rafael J. Wysocki
2009-06-22 15:27 ` [linux-pm] " Rafael J. Wysocki
2009-06-22 15:39 ` Alan Stern
2009-06-22 15:53 ` Rafael J. Wysocki
2009-06-22 15:53 ` [linux-pm] " Rafael J. Wysocki
2009-06-22 15:39 ` Alan Stern
2009-06-22 14:16 ` Alan Stern
2009-06-22 6:20 ` [linux-pm] " Magnus Damm
2009-06-22 6:20 ` Magnus Damm
2009-06-22 6:43 ` Arjan van de Ven
2009-06-22 6:43 ` Arjan van de Ven
2009-06-22 7:27 ` Magnus Damm
2009-06-22 7:27 ` [linux-pm] " Magnus Damm
2009-06-22 13:49 ` Arjan van de Ven
2009-06-22 13:49 ` [linux-pm] " Arjan van de Ven
2009-06-22 13:49 ` Arjan van de Ven
2009-06-22 15:39 ` Rafael J. Wysocki
2009-06-22 15:39 ` [linux-pm] " Rafael J. Wysocki
2009-06-22 15:33 ` Rafael J. Wysocki
2009-06-22 15:33 ` Rafael J. Wysocki
2009-06-22 6:43 ` Arjan van de Ven
2009-06-22 8:15 ` [linux-pm] " Oliver Neukum
2009-06-22 8:15 ` Oliver Neukum
2009-06-22 6:20 ` Magnus Damm
2009-06-20 23:38 ` [patch update 3] " Rafael J. Wysocki
2009-06-21 2:23 ` Alan Stern
2009-06-21 2:23 ` Alan Stern
2009-06-21 2:23 ` Alan Stern
2009-06-21 12:46 ` Rafael J. Wysocki
2009-06-21 12:46 ` Rafael J. Wysocki
2009-06-22 15:01 ` Alan Stern
2009-06-22 15:01 ` Alan Stern
2009-06-22 15:49 ` Rafael J. Wysocki
2009-06-22 15:49 ` Rafael J. Wysocki
2009-06-22 16:28 ` Alan Stern
2009-06-22 16:28 ` Alan Stern
2009-06-22 16:28 ` Alan Stern
2009-06-22 23:02 ` Rafael J. Wysocki
2009-06-22 23:02 ` Rafael J. Wysocki
2009-06-23 17:02 ` Alan Stern
2009-06-23 17:02 ` Alan Stern
2009-06-23 17:02 ` Alan Stern
2009-06-23 17:45 ` Rafael J. Wysocki
2009-06-23 18:26 ` Alan Stern
2009-06-23 18:26 ` Alan Stern
2009-06-23 18:26 ` Alan Stern
2009-06-24 0:17 ` Rafael J. Wysocki
2009-06-24 0:17 ` Rafael J. Wysocki
2009-06-24 14:51 ` Alan Stern
2009-06-24 14:51 ` Alan Stern
2009-06-24 19:14 ` Rafael J. Wysocki
2009-06-24 19:14 ` Rafael J. Wysocki
2009-06-24 20:19 ` Alan Stern
2009-06-24 20:19 ` Alan Stern
2009-06-24 21:23 ` Rafael J. Wysocki
2009-06-24 21:23 ` Rafael J. Wysocki
2009-06-23 17:45 ` Rafael J. Wysocki
2009-06-20 23:38 ` Rafael J. Wysocki
2009-06-19 22:42 ` [patch update 2 fix] " Rafael J. Wysocki
2009-06-17 23:07 ` Rafael J. Wysocki
2009-06-17 20:08 ` Alan Stern
2009-06-16 22:33 ` Rafael J. Wysocki
2009-06-15 23:21 ` [patch update] " Rafael J. Wysocki
2009-06-24 15:04 ` Pavel Machek
2009-06-27 21:52 ` Rafael J. Wysocki
2009-07-06 8:28 ` Pavel Machek
2009-07-06 8:28 ` Pavel Machek
2009-06-27 21:52 ` Rafael J. Wysocki
2009-06-24 15:04 ` Pavel Machek
2009-06-14 22:57 ` Rafael J. Wysocki
2009-06-14 9:58 ` [PATCH] " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='200906152202.32094.rjw__39423.4998304912$1245096166$gmane$org@sisk.pl' \
--to=rjw@sisk.pl \
--cc=arjan@infradead.org \
--cc=damm@igel.co.jp \
--cc=gregkh@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.