All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Network development list <netdev@vger.kernel.org>
Cc: "Aric D. Blumer" <aric@sdgsystems.com>
Subject: [patch] usbnet cdc_subset: fix issues talking to PXA gadgets
Date: Fri, 19 Jun 2009 00:11:28 -0700	[thread overview]
Message-ID: <200906190011.28320.david-b@pacbell.net> (raw)

From: David Brownell <dbrownell@users.sourceforge.net>

The host-side CDC subset driver is binding more specifically
than it should ... only to PXA 210/25x/26x Linux-USB gadgets.

Loosen that restriction to match the gadget driver itself.
This helps various PXA 27x and PXA 3xx devices be happier
when talking to Linux hosts; and a few other gadgets too.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Tested-by: Aric D. Blumer <aric@sdgsystems.com>
---
Appropriate for -stable ... behaves like a protocol bug.

 drivers/net/usb/cdc_subset.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--- a/drivers/net/usb/cdc_subset.c
+++ b/drivers/net/usb/cdc_subset.c
@@ -307,9 +307,10 @@ static const struct usb_device_id	produc
 	USB_DEVICE (0x1286, 0x8001),    // "blob" bootloader
 	.driver_info =  (unsigned long) &blob_info,
 }, {
-	// Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config
-	// e.g. Gumstix, current OpenZaurus, ...
-	USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203),
+	// Linux Ethernet/RNDIS gadget, mostly on PXA, second config
+	// e.g. Gumstix, current OpenZaurus, ... or anything else
+	// that just enables this gadget option.
+	USB_DEVICE_VER (0x0525, 0xa4a2),
 	.driver_info =	(unsigned long) &linuxdev_info,
 },
 #endif

             reply	other threads:[~2009-06-19  7:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19  7:11 David Brownell [this message]
2009-06-19  7:24 ` [patch] usbnet cdc_subset: fix issues talking to PXA gadgets David Miller
2009-06-19  8:07   ` David Miller
2009-06-19 10:13     ` David Brownell
2009-06-19 10:10 ` [patch v2] " David Brownell
2009-06-20  8:22   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906190011.28320.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=aric@sdgsystems.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.