All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: newren@gmail.com
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de, kusambite@gmail.com
Subject: Re: [PATCH 1/7] fast-export: Omit tags that tag trees
Date: Sat, 20 Jun 2009 13:31:28 -0400	[thread overview]
Message-ID: <20090620173128.GE31022@coredump.intra.peff.net> (raw)
In-Reply-To: <1245472623-28103-2-git-send-email-newren@gmail.com>

On Fri, Jun 19, 2009 at 10:36:57PM -0600, newren@gmail.com wrote:

> From: Elijah Newren <newren@gmail.com>
> 
> Commit c0582c53bcf4e83bba70e1ad23abbad31f96ebc8 introduced logic to just
> omit tags that point to tree objects.  However, a case was missed
> resulting in a tag being output which pointed at "mark :0", which would
> cause fast-import to crash.

Do we really want to disallow tags pointing to trees? There is at least
one well-known case in use (kernel v2.6.11).

Also, (and I haven't investigated at all), this sounds like the same
issue we have with tags pointing to tags. IOW, everything referenceable
should be given a mark, but it is not currently. I posted a "how about
this" patch for the tag case here:

  http://article.gmane.org/gmane.comp.version-control.git/119245

but I never got around to following it up with tests. Could you do
something similar for the tree case?

-Peff

  reply	other threads:[~2009-06-20 17:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20  4:36 A few fast-export fixups newren
2009-06-20  4:36 ` [PATCH 1/7] fast-export: Omit tags that tag trees newren
2009-06-20 17:31   ` Jeff King [this message]
2009-06-20 18:01     ` Elijah Newren
2009-06-20 18:52       ` Jeff King
2009-06-20  4:36 ` [PATCH 2/7] Modify fast-export testcase to check that we correctly omit tags of trees newren
2009-06-21  5:53   ` Stephen Boyd
2009-06-21  6:17   ` Johannes Sixt
2009-06-22 13:12     ` Elijah Newren
2009-06-20  4:36 ` [PATCH 3/7] fast-export: Make sure we show actual ref names instead of "(null)" newren
2009-06-20  4:37 ` [PATCH 4/7] fast-export: Do parent rewriting to avoid dropping relevant commits newren
2009-06-20  4:37 ` [PATCH 5/7] fast-export: Add a --tag-of-filtered-object option for newly dangling tags newren
2009-06-20  4:37 ` [PATCH 6/7] Add new fast-export testcases newren
2009-06-20  4:37 ` [PATCH 7/7] fast-export: Document the fact that git-rev-list arguments are accepted newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090620173128.GE31022@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=kusambite@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.