All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: Update MTD infrastructure to support	64bit device size
Date: Mon, 22 Jun 2009 14:01:34 +0200	[thread overview]
Message-ID: <200906221401.35203.sr@denx.de> (raw)
In-Reply-To: <4A3D2044.6090106@googlemail.com>

Hi Dirk,

On Saturday 20 June 2009 19:45:40 Dirk Behme wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> >> 2. C++ style comment. Found by Wolfgang ;)

This is because it's a copy from the Linux code. Not sure if
we should change the coding style here. I really prefer to be
in sync with the Linux version. This makes future updates easier.

> >> 3. The major one: By the new 64bit variables, depending on tool chain,
> >> there are now calls to libgcc introduced. Depending on tool chain,
> >> this might work, or fail. As it does with one of my tool chains, which
> >> worked totally fine until here. It was my understanding that U-Boot
> >> shall not rely on libgcc, i.e. proper tool chain libraries.
> >>
> >> Having CONFIG_SYS_64BIT_VSPRINTF not defined, the linker needs
> >> "_lshrdi3", which comes from nand_base.o and nand_bbt.o. E.g. from
> >> "len = mtd->size >> (this->bbt_erase_shift + 2);" from nand_bbt.c.
> >>
> >> Having CONFIG_SYS_64BIT_VSPRINTF enabled, the linker requests
> >> _lshrdi3, _udivdi3, _umoddi3 and _clz from libgcc.
> >>
> >> Looking into U-Boot's lib_arm/ directory, we have already some low
> >> level math functions there to avoid libgcc. E.g. nand_bbt.c has
> >> references to _ashrdi3, too, but this is resolved by lib_arm's version
> >> what is fine.
> >>
> >> I'd like that NAND code is modified that only math is used which
> >> U-Boot provides and no libgcc is needed.
> >
> > this is a already known problem by Stefan and I and solved
> >
> > two patchs was send to the ML
>
> Thanks for the hint! Do you kindly have the subjects or better links
> to mailing list archive?

http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=cf96e690cb9840b4a5dc7e750be863228550b5ce

and 

http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=c5ae538c9bd359c137d306e431b2589ba91fbc08

both available in the "testing" branch of u-boot-arm.

From you comments on the list I see that you found those patches here
too. :)

Do these patches fix the building problem for you?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-06-22 12:01 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 14:03 [U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size Stefan Roese
2009-05-11 16:27 ` Mike Frysinger
2009-05-11 16:38   ` Stefan Roese
2009-05-11 16:57     ` Mike Frysinger
2009-05-11 20:06       ` Scott Wood
2009-05-11 17:59     ` Wolfgang Denk
2009-05-12  4:39       ` Stefan Roese
2009-05-12  5:11         ` Mike Frysinger
2009-05-12  8:14         ` Wolfgang Denk
2009-05-12  8:26           ` Stefan Roese
2009-06-03 21:49 ` Wolfgang Denk
2009-06-20  5:33 ` Dirk Behme
2009-06-20  8:52   ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-20 17:45     ` Dirk Behme
2009-06-22 12:01       ` Stefan Roese [this message]
2009-06-22 18:10         ` Dirk Behme
2009-06-22 18:21           ` Stefan Roese
2009-06-28  5:47             ` Dirk Behme
2009-06-29 14:35               ` Stefan Roese
2009-06-22 12:55   ` Stefan Roese
2009-06-22 18:12     ` Dirk Behme
2009-06-22 18:25       ` Stefan Roese
2009-06-22 18:38         ` Dirk Behme
2009-06-22 18:50           ` Scott Wood
2009-06-22 19:26             ` Stefan Roese
2009-06-22 19:49               ` Dirk Behme
2009-06-22 19:52                 ` Scott Wood
2009-06-22 20:04                   ` Dirk Behme
2009-06-22 20:08                     ` Scott Wood
2009-06-22 20:15                       ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906221401.35203.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.