From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756279AbZGGCMm (ORCPT ); Mon, 6 Jul 2009 22:12:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754971AbZGGCMf (ORCPT ); Mon, 6 Jul 2009 22:12:35 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:41596 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754508AbZGGCMe (ORCPT ); Mon, 6 Jul 2009 22:12:34 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Minchan Kim Subject: Re: [PATCH 4/5] add isolate pages vmstat Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang , LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel In-Reply-To: <20090707104806.6706ac4a.minchan.kim@barrios-desktop> References: <20090707101855.0C63.A69D9226@jp.fujitsu.com> <20090707104806.6706ac4a.minchan.kim@barrios-desktop> Message-Id: <20090707111030.0C69.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Tue, 7 Jul 2009 11:12:33 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > It looks good to me. > Thanks for your effort. I added my review sign. :) > > Let remain one side note. > This accounting feature results from direct reclaim bomb. > If we prevent direct reclaim bomb, I think this feature can be removed. Hmmm. I disagree. isolated pages can become more than >1GB on server systems. Who want >1GB unaccountable memory? > > As I know, Rik or Wu is making patch for throttling direct reclaim. > > On Tue, 7 Jul 2009 10:19:53 +0900 (JST) > KOSAKI Motohiro wrote: > > > > > > Index: b/mm/vmscan.c > > > > > =================================================================== > > > > > --- a/mm/vmscan.c > > > > > +++ b/mm/vmscan.c > > > > > @@ -1082,6 +1082,7 @@ static unsigned long shrink_inactive_lis > > > > > -count[LRU_ACTIVE_ANON]); > > > > > __mod_zone_page_state(zone, NR_INACTIVE_ANON, > > > > > -count[LRU_INACTIVE_ANON]); > > > > > + __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, nr_taken); > > > > > > > > Lumpy can reclaim file + anon anywhere. > > > > How about using count[NR_LRU_LISTS]? > > > > > > Ah yes, good catch. > > > > Fixed. > > > > Subject: [PATCH] add isolate pages vmstat > > > > If the system have plenty threads or processes, concurrent reclaim can > > isolate very much pages. > > Unfortunately, current /proc/meminfo and OOM log can't show it. > > > > This patch provide the way of showing this information. > > > > > > reproduce way > > ----------------------- > > % ./hackbench 140 process 1000 > > => couse OOM > > > > Active_anon:146 active_file:41 inactive_anon:0 > > inactive_file:0 unevictable:0 > > isolated_anon:49245 isolated_file:113 > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > dirty:0 writeback:0 buffer:49 unstable:0 > > free:184 slab_reclaimable:276 slab_unreclaimable:5492 > > mapped:87 pagetables:28239 bounce:0 > > > > > > Signed-off-by: KOSAKI Motohiro > Reviewed-by: Minchan Kim > > -- > Kind regards, > Minchan Kim > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id D776C6B006A for ; Mon, 6 Jul 2009 21:31:38 -0400 (EDT) Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id n672CZCr004564 for (envelope-from kosaki.motohiro@jp.fujitsu.com); Tue, 7 Jul 2009 11:12:37 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 618C645DE54 for ; Tue, 7 Jul 2009 11:12:35 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 30A6345DE4E for ; Tue, 7 Jul 2009 11:12:35 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 1894E1DB803C for ; Tue, 7 Jul 2009 11:12:35 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.249.87.104]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id B8077E18002 for ; Tue, 7 Jul 2009 11:12:34 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH 4/5] add isolate pages vmstat In-Reply-To: <20090707104806.6706ac4a.minchan.kim@barrios-desktop> References: <20090707101855.0C63.A69D9226@jp.fujitsu.com> <20090707104806.6706ac4a.minchan.kim@barrios-desktop> Message-Id: <20090707111030.0C69.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Tue, 7 Jul 2009 11:12:33 +0900 (JST) Sender: owner-linux-mm@kvack.org To: Minchan Kim Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang , LKML , linux-mm , Andrew Morton , Christoph Lameter , David Rientjes , Rik van Riel List-ID: > It looks good to me. > Thanks for your effort. I added my review sign. :) > > Let remain one side note. > This accounting feature results from direct reclaim bomb. > If we prevent direct reclaim bomb, I think this feature can be removed. Hmmm. I disagree. isolated pages can become more than >1GB on server systems. Who want >1GB unaccountable memory? > > As I know, Rik or Wu is making patch for throttling direct reclaim. > > On Tue, 7 Jul 2009 10:19:53 +0900 (JST) > KOSAKI Motohiro wrote: > > > > > > Index: b/mm/vmscan.c > > > > > =================================================================== > > > > > --- a/mm/vmscan.c > > > > > +++ b/mm/vmscan.c > > > > > @@ -1082,6 +1082,7 @@ static unsigned long shrink_inactive_lis > > > > > -count[LRU_ACTIVE_ANON]); > > > > > __mod_zone_page_state(zone, NR_INACTIVE_ANON, > > > > > -count[LRU_INACTIVE_ANON]); > > > > > + __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, nr_taken); > > > > > > > > Lumpy can reclaim file + anon anywhere. > > > > How about using count[NR_LRU_LISTS]? > > > > > > Ah yes, good catch. > > > > Fixed. > > > > Subject: [PATCH] add isolate pages vmstat > > > > If the system have plenty threads or processes, concurrent reclaim can > > isolate very much pages. > > Unfortunately, current /proc/meminfo and OOM log can't show it. > > > > This patch provide the way of showing this information. > > > > > > reproduce way > > ----------------------- > > % ./hackbench 140 process 1000 > > => couse OOM > > > > Active_anon:146 active_file:41 inactive_anon:0 > > inactive_file:0 unevictable:0 > > isolated_anon:49245 isolated_file:113 > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > dirty:0 writeback:0 buffer:49 unstable:0 > > free:184 slab_reclaimable:276 slab_unreclaimable:5492 > > mapped:87 pagetables:28239 bounce:0 > > > > > > Signed-off-by: KOSAKI Motohiro > Reviewed-by: Minchan Kim > > -- > Kind regards, > Minchan Kim > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org