From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Thu, 9 Jul 2009 22:31:08 +0200
Subject: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board 5/7
In-Reply-To: <4A5639B3.1090604@fearnside-systems.co.uk>
References: <4A42C65C.9050108@fearnside-systems.co.uk>
	<4A42C688.30001@fearnside-systems.co.uk>
	<20090708205451.GD12394@game.jcrosoft.org>
	<4A5639B3.1090604@fearnside-systems.co.uk>
Message-ID: <20090709203108.GN28344@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> >> +	/*
> >> +	 * mask all IRQs by setting all bits in the INTMR - default
> >> +	 */
> >> +	mov	r1, #0xffffffff
> >> +	ldr	r0, =INTMSK
> >> +	str	r1, [r0]
> >> +# if defined(CONFIG_S3C2410) || defined(CONFIG_S3C2440)
> >> +	ldr	r1, =INTSMASK
> >> +	ldr	r0, =INTSUBMSK
> >> +	str	r1, [r0]
> >> +# endif
> >> +
> >> +	/* FCLK:HCLK:PCLK = 1:2:4 */
> >> +	/* default FCLK is 120 MHz ! */
> >> +	ldr	r0, =CLKDIVN
> >> +	mov	r1, #CLKDIVVAL
> >> +	str	r1, [r0]
> >> +
> >> +#ifdef CONFIG_S3C2440
> >> +	/* Set asynchronous bus mode */
> >> +	mrc	p15, 0, r1, c1, c0, 0   /* read ctrl register */
> > whitespace please fix
> >> +	orr	r1, r1, #0xc0000000     /* Asynchronous */
> > whitespace please fix
> >> +	mcr	p15, 0, r1, c1, c0, 0   /* write ctrl register */
> > whitespace please fix
> >> +#endif  /* CONFIG_S3C2440 */
> > whitespace please fix
> 
> I'm not sure what the problem is - should the comments be indented with
> a tab?
no with space here
> 
> By the way, I'm on vacation for the next 2 weeks so I won't be able to
> make the changes before the merge window closes. Do I need to wait until
> v2009.08 is released and re-base my changes to that?
after the merge will be close I'll open the next branch and depending on the
time I may ask to have it for this release to wd
> 
> >> +
> >> +	mov	pc, lr
> >> +
> >> +#endif  /* CONFIG_S3C24X0 */
Best Regards,
J.