From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbZGKTBk (ORCPT ); Sat, 11 Jul 2009 15:01:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751841AbZGKTBb (ORCPT ); Sat, 11 Jul 2009 15:01:31 -0400 Received: from kroah.org ([198.145.64.141]:59549 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbZGKTBa (ORCPT ); Sat, 11 Jul 2009 15:01:30 -0400 Date: Sat, 11 Jul 2009 11:59:20 -0700 From: Greg KH To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg KH , linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform_driver_register: warn if probe is in .init.text Message-ID: <20090711185920.GB25363@kroah.com> References: <20090616182310.GC13048@pengutronix.de> <1245418939-20758-1-git-send-email-u.kleine-koenig@pengutronix.de> <20090619141128.GA11506@suse.de> <20090619144354.GA20985@pengutronix.de> <20090629075535.GA20155@pengutronix.de> <20090711033459.GC1344@suse.de> <20090711100014.GA9540@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20090711100014.GA9540@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2009 at 12:00:14PM +0200, Uwe Kleine-König wrote: > Hi Greg, > > > > Are you conviced and took the patch or did you give up to convince me? > > > > Heh, no, sorry, it got burried in my queue. > > > > > I still think the patch is correct and I'd like to have it applied. > > > > Ok, let's test it out in the linux-next tree for a while to make sure it > > works properly. Care to send me an updated version? > I updated to latest Linus' master. It applies to linux-next from > Fri Jul 10 14:44:30 2009 +1000 as is. > > Back some time I sent a series that fixes many of these bugs. I will > update it later today and resend. > > Best regards and thanks, > Uwe > > ---->8---- > From: Uwe Kleine-König > Subject: [PATCH] platform_driver_register: warn if probe is in .init.text > > with HOTPLUG=y it's wrong to register a platform_driver whose probe > function lives in .init.text because the probe function can be called > (e.g. via sysfs or by registering a device late) after the init sections > are already discarded. This results in an oops. > > So warn if such a driver is registered. > > Without HOTPLUG the probe function can (and should) be discarded if the > driver is registered while the init sections are still available. > In this case warn if the probe function isn't discarded later. (As > described in the comments there is a small chance for a wrong warning. > But as HOTPLUG=n is unusual today and the situation is strage enough to > be cleaned up anyhow, I think this is OK.) > > Signed-off-by: Uwe Kleine-König This code kills the build in very bad ways :( So much so that the error messages scroll away, but it starts out with: In file included from /home/gregkh/work/linux/gregkh-2.6/arch/x86/include/asm/percpu.h:45, from /home/gregkh/work/linux/gregkh-2.6/arch/x86/include/asm/current.h:5, from /home/gregkh/work/linux/gregkh-2.6/arch/x86/include/asm/processor.h:15, from /home/gregkh/work/linux/gregkh-2.6/arch/x86/include/asm/atomic_32.h:6, from /home/gregkh/work/linux/gregkh-2.6/arch/x86/include/asm/atomic.h:2, from include/linux/crypto.h:20, from arch/x86/kernel/asm-offsets_32.c:7, from arch/x86/kernel/asm-offsets.c:2: include/linux/kernel.h: In function ‘core_kernel_init_text’: include/linux/kernel.h:207: error: storage class specified for parameter ‘__kernel_text_address’ include/linux/kernel.h:208: error: storage class specified for parameter ‘kernel_text_address’ include/linux/kernel.h:209: error: storage class specified for parameter ‘kernel_init_text_address’ include/linux/kernel.h:210: error: storage class specified for parameter ‘func_ptr_is_kernel_text’ include/linux/kernel.h:212: warning: empty declaration Care to respin this? thanks, greg k-h