All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <xiyou.wangcong@gmail.com>
To: Frans Pop <elendil@planet.nl>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>,
	x86@kernel.org
Subject: Re: [PATCH] x86: minor Makefile simplification through use of cc-ifversion
Date: Fri, 24 Jul 2009 17:26:44 +0800	[thread overview]
Message-ID: <20090724092644.GE6372@cr0.nay.redhat.com> (raw)
In-Reply-To: <200907232056.28635.elendil@planet.nl>

On Thu, Jul 23, 2009 at 08:56:27PM +0200, Frans Pop wrote:
>Signed-off-by: Frans Pop <elendil@planet.nl>
>---
>
>Change was suggested by Sam Ravnborg; see http://lkml.org/lkml/2009/7/18/15.
>Tested to work correctly.


Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>


>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 1b68659..1f3851a 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -32,8 +32,8 @@ ifeq ($(CONFIG_X86_32),y)
> 
>         # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
>         # a lot more stack due to the lack of sharing of stacklots:
>-        KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
>-                echo $(call cc-option,-fno-unit-at-a-time); fi ;)
>+        KBUILD_CFLAGS += $(call cc-ifversion, -lt, 0400, \
>+				$(call cc-option,-fno-unit-at-a-time))
> 
>         # CPU-specific tuning. Anything which can be shared with UML should go here.
>         include $(srctree)/arch/x86/Makefile_32.cpu
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2009-07-24  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-23 18:56 [PATCH] x86: minor Makefile simplification through use of cc-ifversion Frans Pop
2009-07-23 21:25 ` Sam Ravnborg
2009-07-24  9:26 ` Amerigo Wang [this message]
2009-08-04 13:15 ` [tip:x86/kbuild] x86: Simplify the Makefile in a minor way " tip-bot for Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090724092644.GE6372@cr0.nay.redhat.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=elendil@planet.nl \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.