All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver
Date: Tue, 11 Aug 2009 13:38:07 +0200	[thread overview]
Message-ID: <20090811113807.GQ6108@pengutronix.de> (raw)
In-Reply-To: <20090811101240.GA7572@rakim.wolfsonmicro.main>

Hi Mark,

On Tue, Aug 11, 2009 at 11:12:40AM +0100, Mark Brown wrote:
> On Tue, Aug 11, 2009 at 11:07:43AM +0200, Sascha Hauer wrote:
> 
> > +/*
> > + * Register a client device.  This is non-fatal since there is no need to
> > + * fail the entire device init due to a single platform device failing.
> > + */
> > +static void mc13783_client_dev_register(struct mc13783 *mc13783,
> > +				       const char *name,
> > +				       struct platform_device **pdev)
> 
> Some of this code is looking distinctly familiar :)

Indeed, I added a 'based on' to the header.

> 
> > +#define	SW_SW1A		0
> > +#define	SW_SW1B		1
> 
> This and the other defines following look like they should probably be
> namespaced.

Ok.

Thanks for reviewing. I addressed these comments and the comments you made
to the other patches. I'll delay reposting a bit in case others have
comments aswell.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2009-08-11 12:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11  9:07 [RFC] Freescale MC13783 PMIC support Sascha Hauer
2009-08-11  9:07 ` [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver Sascha Hauer
2009-08-11  9:07   ` [PATCH 2/5] [input] add mc13783 touchscreen driver Sascha Hauer
2009-08-11  9:07     ` Sascha Hauer
2009-08-11  9:07     ` [PATCH 3/5] [hwmon] add Freescale MC13783 adc driver Sascha Hauer
2009-08-11  9:07       ` [lm-sensors] " Sascha Hauer
2009-08-11  9:07       ` [PATCH 4/5] [RTC] Add Freescale MC13783 RTC driver Sascha Hauer
2009-08-11  9:07         ` [PATCH 5/5] [regulator] Add a Freescale MC13783 regulator driver Sascha Hauer
2009-08-11 10:19           ` Mark Brown
2009-08-12  2:15     ` [PATCH 2/5] [input] add mc13783 touchscreen driver Dmitry Torokhov
2009-08-12 11:10       ` Sascha Hauer
2009-08-12 11:16         ` Mark Brown
2009-08-12 11:34           ` Sascha Hauer
2009-08-12 16:01         ` Dmitry Torokhov
2009-08-11 10:12   ` [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver Mark Brown
2009-08-11 11:38     ` Sascha Hauer [this message]
2009-08-11 10:15   ` Mark Brown
2009-08-11 12:05 ` [RFC] Freescale MC13783 PMIC support Antonio Ospite
2009-08-11 12:28   ` Mark Brown
2009-08-15  1:17     ` Daniel Ribeiro
2009-08-11 13:57   ` Sascha Hauer
2009-08-12 15:05 [PATCH V2] " Sascha Hauer
2009-08-12 15:05 ` [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090811113807.GQ6108@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.