From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbZHTMPc (ORCPT ); Thu, 20 Aug 2009 08:15:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753879AbZHTMPc (ORCPT ); Thu, 20 Aug 2009 08:15:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53987 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753602AbZHTMPb (ORCPT ); Thu, 20 Aug 2009 08:15:31 -0400 Date: Thu, 20 Aug 2009 14:15:31 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , LKML , Evgeniy Polyakov , ocfs2-devel@oss.oracle.com, Joel Becker , Felix Blyakher , xfs@oss.sgi.com, Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, OGAWA Hirofumi , linux-ext4@vger.kernel.org, tytso@mit.edu Subject: Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode Message-ID: <20090820121531.GC16486@duck.novell.com> References: <1250697884-22288-1-git-send-email-jack@suse.cz> <1250697884-22288-8-git-send-email-jack@suse.cz> <20090819162638.GE6150@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090819162638.GE6150@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 19-08-09 12:26:38, Christoph Hellwig wrote: > Looks good to me. Eventually we should use those SYNC_ flags also all > through the fsync codepath, but I'll see if I can incorporate that in my > planned fsync rewrite. Yes, I thought I'll leave that for later. BTW it should be fairly easy to teach generic_sync_file() to do fdatawait() before calling ->fsync() if the filesystem sets some flag in inode->i_mapping (or somewhere else) as is needed for XFS, btrfs, etc. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n7KCErW6091054 for ; Thu, 20 Aug 2009 07:15:04 -0500 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 62C901D5D959 for ; Thu, 20 Aug 2009 05:15:36 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id MdwXWXYFNNEmAWBf for ; Thu, 20 Aug 2009 05:15:36 -0700 (PDT) Date: Thu, 20 Aug 2009 14:15:31 +0200 From: Jan Kara Subject: Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode Message-ID: <20090820121531.GC16486@duck.novell.com> References: <1250697884-22288-1-git-send-email-jack@suse.cz> <1250697884-22288-8-git-send-email-jack@suse.cz> <20090819162638.GE6150@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090819162638.GE6150@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, Jan Kara , linux-ntfs-dev@lists.sourceforge.net, LKML , Joel Becker , Anton Altaparmakov , OGAWA Hirofumi , Evgeniy Polyakov , xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com On Wed 19-08-09 12:26:38, Christoph Hellwig wrote: > Looks good to me. Eventually we should use those SYNC_ flags also all > through the fsync codepath, but I'll see if I can incorporate that in my > planned fsync rewrite. Yes, I thought I'll leave that for later. BTW it should be fairly easy to teach generic_sync_file() to do fdatawait() before calling ->fsync() if the filesystem sets some flag in inode->i_mapping (or somewhere else) as is needed for XFS, btrfs, etc. Honza -- Jan Kara SUSE Labs, CR _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Date: Thu, 20 Aug 2009 12:15:36 -0000 Subject: [Ocfs2-devel] [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode In-Reply-To: <20090819162638.GE6150@infradead.org> References: <1250697884-22288-1-git-send-email-jack@suse.cz> <1250697884-22288-8-git-send-email-jack@suse.cz> <20090819162638.GE6150@infradead.org> Message-ID: <20090820121531.GC16486@duck.novell.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Jan Kara , LKML , Evgeniy Polyakov , ocfs2-devel@oss.oracle.com, Joel Becker , Felix Blyakher , xfs@oss.sgi.com, Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, OGAWA Hirofumi , linux-ext4@vger.kernel.org, tytso@mit.edu On Wed 19-08-09 12:26:38, Christoph Hellwig wrote: > Looks good to me. Eventually we should use those SYNC_ flags also all > through the fsync codepath, but I'll see if I can incorporate that in my > planned fsync rewrite. Yes, I thought I'll leave that for later. BTW it should be fairly easy to teach generic_sync_file() to do fdatawait() before calling ->fsync() if the filesystem sets some flag in inode->i_mapping (or somewhere else) as is needed for XFS, btrfs, etc. Honza -- Jan Kara SUSE Labs, CR