From: Denys Fedoryschenko <denys@visp.net.lb>
To: netdev@vger.kernel.org
Subject: iproute2 / tbf with large burst seems broken again
Date: Tue, 25 Aug 2009 02:37:04 +0300 [thread overview]
Message-ID: <200908250237.05017.denys@visp.net.lb> (raw)
Found issue, it seems tc_core_time2tick will overflow with increased
resolution on large bucket values. But no idea how to fix it :-(
I add a warning, something like
unsigned tc_core_time2tick(unsigned time)
{
+ long long temp = time*tick_in_usec;
+ if (temp > INT_MAX)
+ printf("tc_core_time2tick() overflow!\n");
return time*tick_in_usec;
}
Maybe it is good to add in iproute2 mainstream, so user will be warned if
buffer set too large? (and it will not set incorrect values, that lead to
unpredictable results.
next reply other threads:[~2009-08-24 23:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 23:37 Denys Fedoryschenko [this message]
2009-08-25 6:22 ` iproute2 / tbf with large burst seems broken again Jarek Poplawski
2009-08-25 7:34 ` Denys Fedoryschenko
2009-08-25 8:43 ` Jarek Poplawski
2009-08-25 9:00 ` Jarek Poplawski
2009-08-25 9:41 ` Jarek Poplawski
2009-08-25 10:29 ` Denys Fedoryschenko
2009-08-25 11:16 ` Denys Fedoryschenko
2009-08-25 12:13 ` Jarek Poplawski
2009-08-25 12:18 ` Denys Fedoryschenko
2009-08-26 21:59 ` [PATCH] " Jarek Poplawski
2009-08-31 5:05 ` David Miller
2009-08-31 5:30 ` Jarek Poplawski
2009-08-31 5:32 ` David Miller
2009-08-31 8:03 ` Denys Fedoryschenko
2009-08-31 8:18 ` Denys Fedoryschenko
2009-08-31 8:37 ` David Miller
2009-08-31 8:51 ` Denys Fedoryschenko
2009-08-31 9:05 ` Jarek Poplawski
2009-08-31 8:58 ` Jarek Poplawski
2009-09-01 22:51 ` David Miller
2009-08-31 8:49 ` Jarek Poplawski
2009-08-25 20:03 ` Jarek Poplawski
2009-08-26 19:03 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2009-08-24 12:07 Denys Fedoryschenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908250237.05017.denys@visp.net.lb \
--to=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.