From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Ravikiran G Thirumalai <kiran@scalex86.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
shai@scalex86.org, Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id
Date: Tue, 25 Aug 2009 22:59:11 +0400 [thread overview]
Message-ID: <20090825185911.GB5806@lenovo> (raw)
In-Reply-To: <4A943290.5080606@kernel.org>
[Yinghai Lu - Tue, Aug 25, 2009 at 11:50:56AM -0700]
...
| > | We should revert to the .30 behavior unless there's a good reason
| > | (even in that case we'll solve the regression and do a workaround
| > | for vSMP). Yinghai?
| > |
| > | Ingo
| >
| > I'm definitely not APIC expert but since I was partially involved
| > letme turn in.
| >
| > Original commit which causes problem for vSMP seems to be due
| > to cpu_has_apic bit turned off (ie due to being manually disabled
| > or acpi table broken) so further read apic id will return plain
| > zero (we're talking about 64 bits now). So frnakly I don't understand
| > what is wrong with Ravikiran's patch. In case of apic disabled
| > initial apic value will be used anyway (which is latched but
| > actually may be changed, but it's not our case).
|
| initial apic id and apic id could be different.
yes, I know. initial one is latched by pins though still
could be changed (not always).
|
| and we should use initial apic id to get correct phys pkg id in case BIOS set crazy apic id.
indeed, as function name implies. Need more code reading...
So (64 bits) at least generic_identify is not guilty since it uses initial
one from scratch. Need more code reading...
|
| YH
|
-- Cyrill
next prev parent reply other threads:[~2009-08-25 19:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 18:26 [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id Ravikiran G Thirumalai
2009-08-24 23:53 ` Yinghai Lu
2009-08-25 0:27 ` Yinghai Lu
2009-08-25 1:38 ` Ravikiran G Thirumalai
2009-08-25 5:03 ` Yinghai Lu
2009-08-25 1:26 ` Ravikiran G Thirumalai
2009-08-25 5:12 ` Yinghai Lu
2009-08-25 17:17 ` Ravikiran G Thirumalai
2009-08-25 18:15 ` Ingo Molnar
2009-08-25 18:31 ` Cyrill Gorcunov
2009-08-25 18:50 ` Yinghai Lu
2009-08-25 18:57 ` Linus Torvalds
2009-08-25 19:12 ` Ingo Molnar
2009-08-25 19:17 ` Yinghai Lu
2009-08-25 19:24 ` Ingo Molnar
2009-08-25 20:36 ` Ravikiran G Thirumalai
2009-08-25 20:44 ` [PATCH] x86: fix vsmp booting with phys_pkg_id changing Yinghai Lu
2009-08-26 8:08 ` Ingo Molnar
2009-08-26 8:15 ` [tip:x86/urgent] x86: Fix vSMP boot crash tip-bot for Yinghai Lu
2009-08-25 19:53 ` [patch] x86: 2.6.31-rc7 crash due to buggy flat_phys_pkg_id Ravikiran G Thirumalai
2009-08-25 18:59 ` Cyrill Gorcunov [this message]
2009-08-25 19:27 ` Ravikiran G Thirumalai
2009-08-25 19:33 ` Ingo Molnar
2009-08-25 19:36 ` Yinghai Lu
2009-08-25 19:20 ` Ravikiran G Thirumalai
2009-08-25 19:26 ` Ingo Molnar
2009-08-25 19:40 ` Cyrill Gorcunov
2009-08-25 18:35 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090825185911.GB5806@lenovo \
--to=gorcunov@gmail.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shai@scalex86.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.